Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10054012: TabContents -> WebContentsImpl, part 7. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, dcheng, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 7. Move the WebContentsImpl class to files in web_contents. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131845

Patch Set 1 #

Patch Set 2 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3375 lines) Patch
M content/browser/browser_plugin/browser_plugin_web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_frontend_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_request_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/drag_download_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/intent_injector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/web_intents_dispatcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_error_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/tab_contents/tab_contents.h View 1 chunk +0 lines, -698 lines 0 comments Download
D content/browser/tab_contents/tab_contents.cc View 1 chunk +0 lines, -2624 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/test_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_contents_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webkit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/DEPS View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/public/browser/web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layout_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
The only changes are moving the TC files, adjusting the #includes, and rewriting the header ...
8 years, 8 months ago (2012-04-11 16:41:32 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-11 17:36:43 UTC) #2
Avi (use Gerrit)
Oops, forgot the DEPS file.
8 years, 8 months ago (2012-04-11 17:56:57 UTC) #3
jam
slgtm
8 years, 8 months ago (2012-04-11 17:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10054012/5002
8 years, 8 months ago (2012-04-11 18:41:18 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-11 21:44:32 UTC) #6 
Change committed as 131845

Powered by Google App Engine
This is Rietveld 408576698