Issue 10054007: Assert we do not leak requests for the system and safe browsing contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10054007: Assert we do not leak requests for the system and safe browsing contexts. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium

Modified:
8 years, 8 months ago

Reviewers:
eroman, mattm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Assert we do not leak requests for the system and safe browsing contexts. It's possible this will catch some leaks when deployed live. We should be able to analyze the crash dumps and fix the culprits. BUG=90971 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131930

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/io_thread.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/safe_browsing/safe_browsing_service.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10054007/1

8 years, 8 months ago (2012-04-12 01:37:51 UTC) #4

Change committed as 131930

Expand Messages | Collapse Messages