Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10053029: Factor out the code to write control frame headers into a new constructor of SpdyFrameBuilder. (Closed)

Created:
8 years, 8 months ago by Ryan Hamilton
Modified:
8 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Factor out the code to write control and frame headers into a new constructors of SpdyFrameBuilder. Remove unused empty SpdyFrameBuilder constructor. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132428

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Add Data frame constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -121 lines) Patch
M net/spdy/spdy_frame_builder.h View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M net/spdy/spdy_frame_builder.cc View 1 2 1 chunk +40 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 12 chunks +39 lines, -94 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 4 chunks +9 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Hamilton
Merging change from server code.
8 years, 8 months ago (2012-04-11 23:08:45 UTC) #1
Ryan Hamilton
8 years, 8 months ago (2012-04-11 23:14:08 UTC) #2
ramant (doing other things)
lgtm
8 years, 8 months ago (2012-04-11 23:28:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10053029/5001
8 years, 8 months ago (2012-04-14 17:09:31 UTC) #4
commit-bot: I haz the power
Try job failure for 10053029-5001 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 8 months ago (2012-04-14 21:19:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10053029/5001
8 years, 8 months ago (2012-04-15 15:29:40 UTC) #6
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 8 months ago (2012-04-15 20:04:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10053029/5001
8 years, 8 months ago (2012-04-16 16:40:12 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 18:06:12 UTC) #9
Change committed as 132428

Powered by Google App Engine
This is Rietveld 408576698