Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 10051026: avoid race between dir existence check and dir creation (Closed)

Created:
8 years, 8 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

avoid race between dir existence check and dir creation On clean builds, if there's two instances running at the same time makedirs occasionally raises and kills the build. R=ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tools/generate_stubs/generate_stubs.py View 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
8 years, 8 months ago (2012-04-12 20:13:56 UTC) #1
scottmg
friendly ping, any objections to this change?
8 years, 8 months ago (2012-04-24 03:31:14 UTC) #2
Nico
lgtm!
8 years, 8 months ago (2012-04-27 23:18:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10051026/1
8 years, 7 months ago (2012-04-30 18:15:35 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 19:51:30 UTC) #5
Change committed as 134571

Powered by Google App Engine
This is Rietveld 408576698