apk-based test runner work for android

build/android/test_result.py

Index: build/android/test_result.py
diff --git a/build/android/test_result.py b/build/android/test_result.py
index 0c564368a133f7f4d383f4df6cb6c0e1445f7217..12fe9e7c8089842cb24bcc7ddf249dac03691f52 100644
--- a/build/android/test_result.py
+++ b/build/android/test_result.py
@@ -58,13 +58,15 @@ class TestResults(object):
     self.disabled = []
     self.unexpected_pass = []
     self.timed_out = False
+    self.overall_fail = False
 
   @staticmethod
-  def FromOkAndFailed(ok, failed, timed_out=False):
+  def FromOkAndFailed(ok, failed, timed_out=False, overall_fail=False):

[bulach, 2012/04/12 15:51:42]

my rant:
if we had tools to statically check this...
the problem is that it's not possible for reviewers to know whether a param has
a default or not, and then which one that is.. I'd much rather *not* have
default params at all but then again.. :)


http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Default_Argume...
Calling code must use named values for arguments with a default value. This
helps document the code somewhat and helps prevent and detect interface breakage
when more arguments are added.

[John Grabowski, 2012/04/13 01:11:37]

Done.

     ret = TestResults()
     ret.ok = ok
     ret.failed = failed
     ret.timed_out = timed_out
+    ret.overall_fail = overall_fail
     return ret
 
   @staticmethod
@@ -80,6 +82,8 @@ class TestResults(object):
       ret.unexpected_pass += t.unexpected_pass
       if t.timed_out:
         ret.timed_out = True
+      if t.overall_fail:
+        ret.overall_fail = True
     return ret
 
   def _Log(self, sorted_list):