Chromium Code Reviews| Index: base/android/java/base.xml |
| diff --git a/base/android/java/base.xml b/base/android/java/base.xml |
| index 87cd72b53c02b29541377b5e1c5d687e37232025..821175c68e42eae49636c3d6365ac529cc25aa12 100644 |
| --- a/base/android/java/base.xml |
| +++ b/base/android/java/base.xml |
| @@ -7,20 +7,31 @@ |
| <property name="sdk.dir" location="${env.ANDROID_SDK_ROOT}"/> |
| <property name="sdk.version" value="${env.ANDROID_SDK_VERSION}"/> |
| <property name="src" location="."/> |
| - <property name="build" location="build"/> |
| <property name="dist" location="dist"/> |
| + <property name="out.dir" location="${PRODUCT_DIR}"/> |
| + <!-- TODO(jrg): establish a standard for the intermediate java |
| + directories. Settle on a standard once ant/jar build files |
| + like this are androidified --> |
| + <property name="dest.dir" location="${PRODUCT_DIR}/base_java"/> |
|
bulach
2012/04/12 15:51:42
hmm, not too keen on base_java.. how about either:
John Grabowski
2012/04/13 01:11:37
went with java/base to closer reflect other use ca
|
| <target name="init"> |
| <!-- Create the time stamp --> |
| <tstamp/> |
| <!-- Create the build directory structure used by compile --> |
| - <mkdir dir="${build}"/> |
| + <mkdir dir="${out.dir}"/> |
| + <mkdir dir="${dest.dir}"/> |
| </target> |
| <target name="compile" depends="init" |
| description="compile the source " > |
| <!-- Compile the java code from ${src} into ${build} --> |
| - <javac srcdir="${src}" destdir="${build}"> |
| + <!-- TODO(jrg): adapting this to a proper android antfile will |
| + remove warnings like this: |
| + base.xml:23: warning: 'includeantruntime' was not set, |
| + defaulting to build.sysclasspath=last; |
| + set to false for repeatable builds |
| + --> |
| + <javac srcdir="${src}" destdir="${dest.dir}"> |
| <classpath> |
| <path location="${sdk.dir}/platforms/android-${sdk.version}/android.jar"/> |
| </classpath> |
| @@ -32,14 +43,13 @@ |
| <!-- Create the distribution directory --> |
| <mkdir dir="${dist}/lib"/> |
| - <!-- Put everything in ${build} into the chromium_base.jar file --> |
| - <jar jarfile="${dist}/lib/chromium_base.jar" basedir="${build}"/> |
| + <jar jarfile="${out.dir}/chromium_base.jar" basedir="${dest.dir}"/> |
| </target> |
| <target name="clean" |
| description="clean up" > |
| - <!-- Delete the ${build} and ${dist} directory trees --> |
| - <delete dir="${build}"/> |
| + <!-- Delete the appropriate directory trees --> |
| + <delete dir="${dest.dir}"/> |
| <delete dir="${dist}"/> |
| </target> |
| </project> |