Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: base/android/java/base.xml

Issue 10051021: apk-based test runner work for android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/java/java.gyp » ('j') | base/base.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/base.xml
diff --git a/base/android/java/base.xml b/base/android/java/base.xml
index 87cd72b53c02b29541377b5e1c5d687e37232025..bfe52068ee2f7f6900300938bd64c28b42066339 100644
--- a/base/android/java/base.xml
+++ b/base/android/java/base.xml
@@ -7,20 +7,31 @@
<property name="sdk.dir" location="${env.ANDROID_SDK_ROOT}"/>
<property name="sdk.version" value="${env.ANDROID_SDK_VERSION}"/>
<property name="src" location="."/>
- <property name="build" location="build"/>
<property name="dist" location="dist"/>
+ <property name="out.dir" location="${PRODUCT_DIR}"/>
+ <!-- TODO(jrg): establish a standard for the intermediate java
+ directories. Settle on a standard once ant/jar build files
+ like this are androidified -->
+ <property name="dest.dir" location="${PRODUCT_DIR}/java/base"/>
<target name="init">
<!-- Create the time stamp -->
<tstamp/>
<!-- Create the build directory structure used by compile -->
- <mkdir dir="${build}"/>
+ <mkdir dir="${out.dir}"/>
+ <mkdir dir="${dest.dir}"/>
</target>
<target name="compile" depends="init"
description="compile the source " >
<!-- Compile the java code from ${src} into ${build} -->
- <javac srcdir="${src}" destdir="${build}">
+ <!-- TODO(jrg): adapting this to a proper android antfile will
+ remove warnings like this:
+ base.xml:23: warning: 'includeantruntime' was not set,
+ defaulting to build.sysclasspath=last;
+ set to false for repeatable builds
+ -->
+ <javac srcdir="${src}" destdir="${dest.dir}">
<classpath>
<path location="${sdk.dir}/platforms/android-${sdk.version}/android.jar"/>
</classpath>
@@ -32,14 +43,13 @@
<!-- Create the distribution directory -->
<mkdir dir="${dist}/lib"/>
- <!-- Put everything in ${build} into the chromium_base.jar file -->
- <jar jarfile="${dist}/lib/chromium_base.jar" basedir="${build}"/>
+ <jar jarfile="${out.dir}/chromium_base.jar" basedir="${dest.dir}"/>
</target>
<target name="clean"
description="clean up" >
- <!-- Delete the ${build} and ${dist} directory trees -->
- <delete dir="${build}"/>
+ <!-- Delete the appropriate directory trees -->
+ <delete dir="${dest.dir}"/>
<delete dir="${dist}"/>
</target>
</project>
« no previous file with comments | « no previous file | base/android/java/java.gyp » ('j') | base/base.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698