chrome/browser/ui/panels/docked_panel_strip.cc - Issue 10051020: Move full-screen detection logic from PanelManager to DisplaySettingsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/docked_panel_strip.cc

Issue 10051020: Move full-screen detection logic from PanelManager to DisplaySettingsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix per feedback Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/base_panel_browser_test.cc ('K') | « chrome/browser/ui/panels/display_settings_provider_win.cc ('k') | chrome/browser/ui/panels/overflow_panel_strip.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/docked_panel_strip.cc

diff --git a/chrome/browser/ui/panels/docked_panel_strip.cc b/chrome/browser/ui/panels/docked_panel_strip.cc

index 6c1c641df97200073285312344ff23c1b753fd6c..4de0c68449b27021090ac1137f70ea5fe2a4cc15 100644

--- a/chrome/browser/ui/panels/docked_panel_strip.cc

+++ b/chrome/browser/ui/panels/docked_panel_strip.cc

@@ -65,13 +65,14 @@ DockedPanelStrip::DockedPanelStrip(PanelManager* panel_manager)

delayed_titlebar_action_(NO_ACTION),

titlebar_action_factory_(this) {

dragging_panel_current_iterator_ = panels_.end();

- panel_manager_->display_settings_provider()->set_desktop_bar_observer(this);

+ panel_manager_->display_settings_provider()->AddDesktopBarObserver(this);

}

DockedPanelStrip::~DockedPanelStrip() {

DCHECK(panels_.empty());

DCHECK(panels_in_temporary_layout_.empty());

DCHECK_EQ(0, minimized_panel_count_);

+ panel_manager_->display_settings_provider()->RemoveDesktopBarObserver(this);

}

void DockedPanelStrip::SetDisplayArea(const gfx::Rect& display_area) {