Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/ui/panels/display_settings_provider.cc

Issue 10051020: Move full-screen detection logic from PanelManager to DisplaySettingsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix linux asan Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/display_settings_provider.h" 5 #include "chrome/browser/ui/panels/display_settings_provider.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/fullscreen.h"
8 #include "ui/gfx/screen.h" 9 #include "ui/gfx/screen.h"
9 10
11 namespace {
12 // The polling interval to check any display settings change, like full-screen
13 // mode changes.
14 const int kFullScreenModeCheckIntervalMs = 1000;
15 } // namespace
16
10 DisplaySettingsProvider::DisplaySettingsProvider() 17 DisplaySettingsProvider::DisplaySettingsProvider()
11 : display_area_observer_(NULL), 18 : is_full_screen_(false) {
12 desktop_bar_observer_(NULL) {
13 } 19 }
14 20
15 DisplaySettingsProvider::~DisplaySettingsProvider() { 21 DisplaySettingsProvider::~DisplaySettingsProvider() {
16 } 22 }
17 23
24 void DisplaySettingsProvider::AddDisplayAreaObserver(
25 DisplayAreaObserver* observer) {
26 display_area_observers_.AddObserver(observer);
27 }
28
29 void DisplaySettingsProvider::RemoveDisplayAreaObserver(
30 DisplayAreaObserver* observer) {
31 display_area_observers_.RemoveObserver(observer);
32 }
33
34 void DisplaySettingsProvider::AddDesktopBarObserver(
35 DesktopBarObserver* observer) {
36 desktop_bar_observers_.AddObserver(observer);
37 }
38
39 void DisplaySettingsProvider::RemoveDesktopBarObserver(
40 DesktopBarObserver* observer) {
41 desktop_bar_observers_.RemoveObserver(observer);
42 }
43
44 void DisplaySettingsProvider::AddFullScreenObserver(
45 FullScreenObserver* observer) {
46 full_screen_observers_.AddObserver(observer);
47
48 if (full_screen_observers_.size() == 1) {
49 full_screen_mode_timer_.Start(FROM_HERE,
50 base::TimeDelta::FromMilliseconds(kFullScreenModeCheckIntervalMs),
51 this, &DisplaySettingsProvider::CheckFullScreenMode);
52 }
53 }
54
55 void DisplaySettingsProvider::RemoveFullScreenObserver(
56 FullScreenObserver* observer) {
57 full_screen_observers_.RemoveObserver(observer);
58
59 if (full_screen_observers_.size() == 0)
60 full_screen_mode_timer_.Stop();
61 }
62
18 gfx::Rect DisplaySettingsProvider::GetDisplayArea() { 63 gfx::Rect DisplaySettingsProvider::GetDisplayArea() {
19 // Do the first-time initialization if not yet. 64 // Do the first-time initialization if not yet.
20 if (adjusted_work_area_.IsEmpty()) 65 if (adjusted_work_area_.IsEmpty())
21 OnDisplaySettingsChanged(); 66 OnDisplaySettingsChanged();
22 67
23 return adjusted_work_area_; 68 return adjusted_work_area_;
24 } 69 }
25 70
26 gfx::Rect DisplaySettingsProvider::GetWorkArea() const { 71 gfx::Rect DisplaySettingsProvider::GetWorkArea() const {
27 #if defined(OS_MACOSX) 72 #if defined(OS_MACOSX)
(...skipping 12 matching lines...) Expand all
40 return; 85 return;
41 work_area_ = work_area; 86 work_area_ = work_area;
42 87
43 OnAutoHidingDesktopBarChanged(); 88 OnAutoHidingDesktopBarChanged();
44 } 89 }
45 90
46 void DisplaySettingsProvider::OnAutoHidingDesktopBarChanged() { 91 void DisplaySettingsProvider::OnAutoHidingDesktopBarChanged() {
47 gfx::Rect old_adjusted_work_area = adjusted_work_area_; 92 gfx::Rect old_adjusted_work_area = adjusted_work_area_;
48 AdjustWorkAreaForAutoHidingDesktopBars(); 93 AdjustWorkAreaForAutoHidingDesktopBars();
49 94
50 if (old_adjusted_work_area != adjusted_work_area_ && display_area_observer_) 95 if (old_adjusted_work_area != adjusted_work_area_) {
51 display_area_observer_->OnDisplayAreaChanged(adjusted_work_area_); 96 FOR_EACH_OBSERVER(DisplayAreaObserver,
97 display_area_observers_,
98 OnDisplayAreaChanged(adjusted_work_area_));
99 }
52 } 100 }
53 101
54 bool DisplaySettingsProvider::IsAutoHidingDesktopBarEnabled( 102 bool DisplaySettingsProvider::IsAutoHidingDesktopBarEnabled(
55 DesktopBarAlignment alignment) { 103 DesktopBarAlignment alignment) {
56 return false; 104 return false;
57 } 105 }
58 106
59 int DisplaySettingsProvider::GetDesktopBarThickness( 107 int DisplaySettingsProvider::GetDesktopBarThickness(
60 DesktopBarAlignment alignment) const { 108 DesktopBarAlignment alignment) const {
61 return 0; 109 return 0;
(...skipping 18 matching lines...) Expand all
80 adjusted_work_area_.set_width(adjusted_work_area_.width() - space); 128 adjusted_work_area_.set_width(adjusted_work_area_.width() - space);
81 } 129 }
82 if (IsAutoHidingDesktopBarEnabled( 130 if (IsAutoHidingDesktopBarEnabled(
83 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT)) { 131 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT)) {
84 int space = GetDesktopBarThickness( 132 int space = GetDesktopBarThickness(
85 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT); 133 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT);
86 adjusted_work_area_.set_width(adjusted_work_area_.width() - space); 134 adjusted_work_area_.set_width(adjusted_work_area_.width() - space);
87 } 135 }
88 } 136 }
89 137
138 void DisplaySettingsProvider::CheckFullScreenMode() {
139 bool is_full_screen = IsFullScreenMode();
140 if (is_full_screen == is_full_screen_)
141 return;
142 is_full_screen_ = is_full_screen;
143
144 FOR_EACH_OBSERVER(FullScreenObserver,
145 full_screen_observers_,
146 OnFullScreenModeChanged(is_full_screen_));
147 }
148
90 #if defined(USE_AURA) 149 #if defined(USE_AURA)
91 // static 150 // static
92 DisplaySettingsProvider* DisplaySettingsProvider::Create() { 151 DisplaySettingsProvider* DisplaySettingsProvider::Create() {
93 return new DisplaySettingsProvider(); 152 return new DisplaySettingsProvider();
94 } 153 }
95 #endif 154 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/display_settings_provider.h ('k') | chrome/browser/ui/panels/display_settings_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698