Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/panels/display_settings_provider.cc

Issue 10051020: Move full-screen detection logic from PanelManager to DisplaySettingsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/display_settings_provider.h" 5 #include "chrome/browser/ui/panels/display_settings_provider.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/fullscreen.h"
8 #include "ui/gfx/screen.h" 9 #include "ui/gfx/screen.h"
9 10
11 namespace {
12 // The polling interval to check any display settings change, like full-screen
13 // mode changes.
14 const int kFullScreenModeCheckIntervalMs = 1000;
15 } // namespace
16
10 DisplaySettingsProvider::DisplaySettingsProvider() 17 DisplaySettingsProvider::DisplaySettingsProvider()
11 : display_area_observer_(NULL), 18 : is_full_screen_(false) {
12 desktop_bar_observer_(NULL) {
13 } 19 }
14 20
15 DisplaySettingsProvider::~DisplaySettingsProvider() { 21 DisplaySettingsProvider::~DisplaySettingsProvider() {
16 } 22 }
17 23
24 void DisplaySettingsProvider::AddObserver(Observer* observer) {
25 switch (observer->type()) {
26 case DISPLAY_AREA_OBSERVER:
27 display_area_observers_.AddObserver(
28 static_cast<DisplayAreaObserver*>(observer));
29 break;
30 case DESKTOP_BAR_OBSERVER:
31 desktop_bar_observers_.AddObserver(
32 static_cast<DesktopBarObserver*>(observer));
33 break;
34 case FULL_SCREEN_OBSERVER:
35 full_screen_observers_.AddObserver(
36 static_cast<FullScreenObserver*>(observer));
37 if (full_screen_observers_.size() == 1) {
38 full_screen_mode_timer_.Start(FROM_HERE,
39 base::TimeDelta::FromMilliseconds(kFullScreenModeCheckIntervalMs),
40 this, &DisplaySettingsProvider::CheckFullScreenMode);
41 }
42 break;
43 default:
44 NOTREACHED();
45 break;
46 }
47 }
48
49 void DisplaySettingsProvider::RemoveObserver(Observer* observer) {
50 switch (observer->type()) {
51 case DISPLAY_AREA_OBSERVER:
52 display_area_observers_.RemoveObserver(
53 static_cast<DisplayAreaObserver*>(observer));
54 break;
55 case DESKTOP_BAR_OBSERVER:
56 desktop_bar_observers_.RemoveObserver(
57 static_cast<DesktopBarObserver*>(observer));
58 break;
59 case FULL_SCREEN_OBSERVER:
60 full_screen_observers_.RemoveObserver(
61 static_cast<FullScreenObserver*>(observer));
62 if (full_screen_observers_.size() == 0)
63 full_screen_mode_timer_.Stop();
64 break;
65 default:
66 NOTREACHED();
67 break;
68 }
69 }
70
18 gfx::Rect DisplaySettingsProvider::GetDisplayArea() { 71 gfx::Rect DisplaySettingsProvider::GetDisplayArea() {
19 // Do the first-time initialization if not yet. 72 // Do the first-time initialization if not yet.
20 if (adjusted_work_area_.IsEmpty()) 73 if (adjusted_work_area_.IsEmpty())
21 OnDisplaySettingsChanged(); 74 OnDisplaySettingsChanged();
22 75
23 return adjusted_work_area_; 76 return adjusted_work_area_;
24 } 77 }
25 78
26 gfx::Rect DisplaySettingsProvider::GetWorkArea() const { 79 gfx::Rect DisplaySettingsProvider::GetWorkArea() const {
27 #if defined(OS_MACOSX) 80 #if defined(OS_MACOSX)
(...skipping 12 matching lines...) Expand all
40 return; 93 return;
41 work_area_ = work_area; 94 work_area_ = work_area;
42 95
43 OnAutoHidingDesktopBarChanged(); 96 OnAutoHidingDesktopBarChanged();
44 } 97 }
45 98
46 void DisplaySettingsProvider::OnAutoHidingDesktopBarChanged() { 99 void DisplaySettingsProvider::OnAutoHidingDesktopBarChanged() {
47 gfx::Rect old_adjusted_work_area = adjusted_work_area_; 100 gfx::Rect old_adjusted_work_area = adjusted_work_area_;
48 AdjustWorkAreaForAutoHidingDesktopBars(); 101 AdjustWorkAreaForAutoHidingDesktopBars();
49 102
50 if (old_adjusted_work_area != adjusted_work_area_ && display_area_observer_) 103 if (old_adjusted_work_area != adjusted_work_area_) {
51 display_area_observer_->OnDisplayAreaChanged(adjusted_work_area_); 104 FOR_EACH_OBSERVER(DisplayAreaObserver,
105 display_area_observers_,
106 OnDisplayAreaChanged(adjusted_work_area_));
107 }
52 } 108 }
53 109
54 bool DisplaySettingsProvider::IsAutoHidingDesktopBarEnabled( 110 bool DisplaySettingsProvider::IsAutoHidingDesktopBarEnabled(
55 DesktopBarAlignment alignment) { 111 DesktopBarAlignment alignment) {
56 return false; 112 return false;
57 } 113 }
58 114
59 int DisplaySettingsProvider::GetDesktopBarThickness( 115 int DisplaySettingsProvider::GetDesktopBarThickness(
60 DesktopBarAlignment alignment) const { 116 DesktopBarAlignment alignment) const {
61 return 0; 117 return 0;
(...skipping 18 matching lines...) Expand all
80 adjusted_work_area_.set_width(adjusted_work_area_.width() - space); 136 adjusted_work_area_.set_width(adjusted_work_area_.width() - space);
81 } 137 }
82 if (IsAutoHidingDesktopBarEnabled( 138 if (IsAutoHidingDesktopBarEnabled(
83 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT)) { 139 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT)) {
84 int space = GetDesktopBarThickness( 140 int space = GetDesktopBarThickness(
85 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT); 141 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT);
86 adjusted_work_area_.set_width(adjusted_work_area_.width() - space); 142 adjusted_work_area_.set_width(adjusted_work_area_.width() - space);
87 } 143 }
88 } 144 }
89 145
146 void DisplaySettingsProvider::CheckFullScreenMode() {
147 bool is_full_screen = IsFullScreenMode();
148 if (is_full_screen == is_full_screen_)
149 return;
150 is_full_screen_ = is_full_screen;
151
152 FOR_EACH_OBSERVER(FullScreenObserver,
153 full_screen_observers_,
154 OnFullScreenModeChanged(is_full_screen_));
155 }
156
90 #if defined(USE_AURA) 157 #if defined(USE_AURA)
91 // static 158 // static
92 DisplaySettingsProvider* DisplaySettingsProvider::Create() { 159 DisplaySettingsProvider* DisplaySettingsProvider::Create() {
93 return new DisplaySettingsProvider(); 160 return new DisplaySettingsProvider();
94 } 161 }
95 #endif 162 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698