Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10051017: Modify Comment of BrowserMainLoop. (Closed)

Created:
8 years, 8 months ago by simonhong_
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Modify Comment of BrowserMainLoop. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132070

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/browser_main_loop.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
simonhong_
8 years, 8 months ago (2012-04-11 21:23:13 UTC) #1
sky
http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h File content/browser/browser_main_loop.h (right): http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h#newcode45 content/browser/browser_main_loop.h:45: // Implements the main browser loop stages called from ...
8 years, 8 months ago (2012-04-11 22:07:04 UTC) #2
simonhong_
On 2012/04/11 22:07:04, sky wrote: > http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h > File content/browser/browser_main_loop.h (right): > > http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h#newcode45 > ...
8 years, 8 months ago (2012-04-11 22:36:52 UTC) #3
simonhong_
On 2012/04/11 22:07:04, sky wrote: > http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h > File content/browser/browser_main_loop.h (right): > > http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h#newcode45 > ...
8 years, 8 months ago (2012-04-11 22:36:54 UTC) #4
simonhong_
I removed '|' from comment. Thank you. http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h File content/browser/browser_main_loop.h (right): http://codereview.chromium.org/10051017/diff/1/content/browser/browser_main_loop.h#newcode45 content/browser/browser_main_loop.h:45: // Implements ...
8 years, 8 months ago (2012-04-12 20:19:48 UTC) #5
sky
LGTM
8 years, 8 months ago (2012-04-12 20:45:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10051017/6001
8 years, 8 months ago (2012-04-12 20:46:24 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 22:14:36 UTC) #8
Change committed as 132070

Powered by Google App Engine
This is Rietveld 408576698