Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 10050032: Print out the error when loading an extension fails. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use ReportExtensionLoadError to match other callsites. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/installed_loader.cc
diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc
index b11c87de10ece207d238b24f37e742104027fb45..4cd5af22b56451124723b0c614756014e2e983da 100644
--- a/chrome/browser/extensions/installed_loader.cc
+++ b/chrome/browser/extensions/installed_loader.cc
@@ -142,12 +142,16 @@ void InstalledLoader::LoadAllExtensions() {
GetCreationFlags(info),
&error));
- if (extension.get()) {
- extensions_info->at(i)->extension_manifest.reset(
- static_cast<DictionaryValue*>(
- extension->manifest()->value()->DeepCopy()));
- should_write_prefs = true;
+ if (!extension.get()) {
+ extension_service_->
+ ReportExtensionLoadError(info->extension_path, error, false);
+ continue;
}
+
+ extensions_info->at(i)->extension_manifest.reset(
+ static_cast<DictionaryValue*>(
+ extension->manifest()->value()->DeepCopy()));
+ should_write_prefs = true;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698