Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/ui/browser_init.cc

Issue 10049005: Fix homepage migration for users who never changed their settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Value -> base::Value Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_init.cc
diff --git a/chrome/browser/ui/browser_init.cc b/chrome/browser/ui/browser_init.cc
index f021a8d4f4fd6031b61c317bfc3a761d285ffcca..6fb122a8bd2529e6df27eeea77713209bead106a 100644
--- a/chrome/browser/ui/browser_init.cc
+++ b/chrome/browser/ui/browser_init.cc
@@ -1194,10 +1194,9 @@ Browser* BrowserInit::LaunchWithProfile::ProcessSpecifiedURLs(
UrlsToTabs(urls, &tabs);
} else if (pref.type == SessionStartupPref::HOMEPAGE) {
- // If the user had 'homepage' selected, we should have migrated them to
- // 'URLs' instead.
- DLOG(ERROR) << "pref.type == HOMEPAGE";
- NOTREACHED();
+ // If 'homepage' selected, either by the user or by a policy, we should
+ // have migrated them to another value.
+ NOTREACHED() << "SessionStartupPref has deprecated type HOMEPAGE";
}
if (tabs.empty())

Powered by Google App Engine
This is Rietveld 408576698