Stop displaying button to launch system print dialog when preview fails.

Stop displaying button to launch system print dialog when preview fails.


BUG=122878
TEST=Verify 122878


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132481

[Scott Byer, 2012-04-12 16:43:39]

lgtm

[commit-bot: I haz the power, 2012-04-12 16:45:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/10048009/1

[commit-bot: I haz the power, 2012-04-12 16:45:44]

Presubmit check for 10048009-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources/print_preview

Presubmit checks took 1.3s to calculate.

[Albert Bodenhamer, 2012-04-12 16:51:55]

Demetrios, can you take a quick look at this?

[dpapad1, 2012-04-12 17:50:42]

On 2012/04/12 16:51:55, Albert Bodenhamer wrote:
> Demetrios, can you take a quick look at this?

Not sure if we should remove the button. The controls on the left are disabled
(grayed out) when an error occurs. Even though the link is not disabled, I
believe it is less probable for users to try to click the link when an error
occurs compared to clicking on the button. Maybe we aslk a UX person to take a
decision on this.

[Albert Bodenhamer, 2012-04-12 17:59:26]

+Akshay
On Thu, Apr 12, 2012 at 10:50 AM, <dpapad@google.com> wrote:

> On 2012/04/12 16:51:55, Albert Bodenhamer wrote:
>
>> Demetrios, can you take a quick look at this?
>>
>
> Not sure if we should remove the button. The controls on the left are
> disabled
> (grayed out) when an error occurs. Even though the link is not disabled, I
> believe it is less probable for users to try to click the link when an
> error
> occurs compared to clicking on the button. Maybe we aslk a UX person to
> take a
> decision on this.
>
>
The issue is that the button generally doesn't resolve the issue when a
preview failure occurs.  It just takes the user farther down a rabbit hole
of failures.  Offering it as a solution just increases confusion in this
case.


>
http://codereview.chromium.**org/10048009/<http://codereview.chromium.org/100...
>



-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

[dpapad, 2012-04-12 18:07:14]

I am sure this button made more sense when print preview was still more buggy,
which resulted in that button working properly more often. Just a little bit
concerned about the discoverability of the link when the other settings are
disabled. I am fine with removing the button if it does not work in most of the
cases, but we should at least update the error string to mention something like
"Print preview failed. Try printing using the system dialog link on the left".

On 2012/04/12 17:59:26, Albert Bodenhamer wrote:
> +Akshay
> On Thu, Apr 12, 2012 at 10:50 AM, <mailto:dpapad@google.com> wrote:
> 
> > On 2012/04/12 16:51:55, Albert Bodenhamer wrote:
> >
> >> Demetrios, can you take a quick look at this?
> >>
> >
> > Not sure if we should remove the button. The controls on the left are
> > disabled
> > (grayed out) when an error occurs. Even though the link is not disabled, I
> > believe it is less probable for users to try to click the link when an
> > error
> > occurs compared to clicking on the button. Maybe we aslk a UX person to
> > take a
> > decision on this.
> >
> >
> The issue is that the button generally doesn't resolve the issue when a
> preview failure occurs.  It just takes the user farther down a rabbit hole
> of failures.  Offering it as a solution just increases confusion in this
> case.
> 
> 
> >
>
http://codereview.chromium.**org/10048009/%3Chttp://codereview.chromium.org/1...>
> >
> 
> 
> 
> -- 
> Albert Bodenhamer | Software Engineer |
mailto:abodenha@chromium.<abodenha@google.com>
> org

[dpapad, 2012-04-16 20:11:06]

LGTM. As stated in the discussion thread, I don't have a strong opinion about
removing the button. Since the button is not working in most of the errors
observed (as stated by the bug description) removing it seems reasonable.

[commit-bot: I haz the power, 2012-04-16 21:01:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/10048009/1

[commit-bot: I haz the power, 2012-04-16 22:44:03]

Change committed as 132481