Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10041015: Change extension permissions increase alert icon to green arrow. (Closed)

Created:
8 years, 8 months ago by Yoyo Zhou
Modified:
8 years, 8 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Change extension permissions increase alert icon to green arrow. BUG=122666 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133407

Patch Set 1 #

Patch Set 2 : # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/extensions/extension_disabled_ui.cc View 1 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
We do have some other choices in the existing icon set. Apparently the Chrome update ...
8 years, 8 months ago (2012-04-18 00:09:38 UTC) #1
Aaron Boodman
What happens if Chrome needs to update at the same time and is at the ...
8 years, 8 months ago (2012-04-21 00:45:59 UTC) #2
Yoyo Zhou
I believe Chrome wins. (Previously I'd tested it with Chrome needing to update, and the ...
8 years, 8 months ago (2012-04-21 08:05:22 UTC) #3
Aaron Boodman
OK, that seems reasonable. LGTM On Sat, Apr 21, 2012 at 1:05 AM, Yoyo Zhou ...
8 years, 8 months ago (2012-04-21 08:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10041015/2001
8 years, 8 months ago (2012-04-21 18:29:06 UTC) #5
commit-bot: I haz the power
Try job failure for 10041015-2001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=19173 Step "update" is always ...
8 years, 8 months ago (2012-04-21 18:30:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10041015/2001
8 years, 8 months ago (2012-04-23 04:45:13 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 05:58:43 UTC) #8
Change committed as 133407

Powered by Google App Engine
This is Rietveld 408576698