Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 10038034: Implemented a "Last Updated" field for the about page of Chrome OS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moved #include out of #if defined(OS_CHROMEOS) Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index 6f3a246be2f659665f21efb848e254bb3cae6b65..41b923d4dd60fdf57cacd7b0a9209de525c29529 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -34,13 +34,18 @@
#include "webkit/glue/webkit_glue.h"
#if defined(OS_CHROMEOS)
+#include "base/i18n/time_formatting.h"
+#include "base/file_util_proxy.h"
+#include "base/sys_info.h"
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/chromeos/cros_settings.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/prefs/pref_service.h"
+#include "content/public/browser/browser_thread.h"
#endif
using base::ListValue;
+using content::BrowserThread;
namespace {
@@ -90,12 +95,18 @@ bool CanChangeReleaseChannel() {
return false;
}
+// Pointer to a |StringValue| holding the date of the last update to Chromium
+// OS. Because this value is obtained by reading a file, it is cached here to
+// prevent the need to read from the file system multiple times unnecessarily.
+Value* g_last_updated_string = NULL;
+
#endif // defined(OS_CHROMEOS)
} // namespace
HelpHandler::HelpHandler()
- : version_updater_(VersionUpdater::Create()) {
+ : version_updater_(VersionUpdater::Create()),
+ ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
}
HelpHandler::~HelpHandler() {
@@ -136,6 +147,7 @@ void HelpHandler::GetLocalizedValues(DictionaryValue* localized_strings) {
{ "webkit", IDS_WEBKIT },
{ "userAgent", IDS_ABOUT_VERSION_USER_AGENT },
{ "commandLine", IDS_ABOUT_VERSION_COMMAND_LINE },
+ { "lastUpdated", IDS_ABOUT_VERSION_LAST_UPDATED },
#endif
#if defined(OS_MACOSX)
{ "promote", IDS_ABOUT_CHROME_PROMOTE_UPDATER },
@@ -235,6 +247,19 @@ void HelpHandler::OnPageLoaded(const ListValue* args) {
base::Value::CreateBooleanValue(CanChangeReleaseChannel()));
web_ui()->CallJavascriptFunction(
"help.HelpPage.updateEnableReleaseChannel", *can_change_channel_value);
+
+ if (g_last_updated_string == NULL) {
+ // If |g_last_updated_string| is |NULL|, the date has not yet been assigned.
+ // Get the date of the last lsb-release file modification.
+ base::FileUtilProxy::GetFileInfo(
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
+ base::SysInfo::GetLsbReleaseFilePath(),
+ base::Bind(&HelpHandler::ProcessLsbFileInfo,
+ weak_factory_.GetWeakPtr()));
+ } else {
+ web_ui()->CallJavascriptFunction("help.HelpPage.setLastUpdated",
+ *g_last_updated_string);
+ }
#endif // defined(OS_CHROMEOS)
version_updater_->CheckForUpdate(
@@ -380,4 +405,32 @@ void HelpHandler::OnReleaseChannel(const std::string& channel) {
web_ui()->CallJavascriptFunction(
"help.HelpPage.updateSelectedChannel", *channel_string);
}
+
+void HelpHandler::ProcessLsbFileInfo(
+ base::PlatformFileError error, const base::PlatformFileInfo& file_info) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+ // If |g_last_updated_string| is not |NULL|, then the file's information has
+ // already been retrieved by another tab.
+ if (g_last_updated_string == NULL) {
+ base::Time time;
+ if (error == base::PLATFORM_FILE_OK) {
+ // Retrieves the approximate time at which Chrome OS was last updated.
+ // Each time a new build is created, /etc/lsb-release is modified with the
+ // new version numbers of the release.
+ time = file_info.last_modified;
+ } else {
+ // If the time of the last update cannot be retrieved, return and do not
+ // display the "Last Updated" section.
+ return;
+ }
+
+ // Note that this string will be internationalized.
+ string16 last_updated = base::TimeFormatFriendlyDate(time);
+ g_last_updated_string = Value::CreateStringValue(last_updated);
+ }
+
+ web_ui()->CallJavascriptFunction("help.HelpPage.setLastUpdated",
+ *g_last_updated_string);
+}
#endif // defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698