Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: content/browser/web_contents/web_contents_delegate_unittest.cc

Issue 10038026: TabContents -> WebContentsImpl, part 12. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/compiler_specific.h" 5 #include "base/compiler_specific.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "content/browser/web_contents/web_contents_impl.h" 8 #include "content/browser/web_contents/web_contents_impl.h"
9 #include "content/public/browser/web_contents_delegate.h" 9 #include "content/public/browser/web_contents_delegate.h"
10 #include "content/test/test_browser_context.h" 10 #include "content/test/test_browser_context.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace { 13 namespace {
14 14
15 class MockWebContentsDelegate : public content::WebContentsDelegate { 15 class MockWebContentsDelegate : public content::WebContentsDelegate {
16 public: 16 public:
17 virtual ~MockWebContentsDelegate() {} 17 virtual ~MockWebContentsDelegate() {}
18 }; 18 };
19 19
20 TEST(WebContentsDelegateTest, UnregisterInDestructor) { 20 TEST(WebContentsDelegateTest, UnregisterInDestructor) {
21 MessageLoop loop(MessageLoop::TYPE_UI); 21 MessageLoop loop(MessageLoop::TYPE_UI);
22 TestBrowserContext browser_context; 22 TestBrowserContext browser_context;
23 23
24 scoped_ptr<TabContents> contents_a( 24 scoped_ptr<WebContentsImpl> contents_a(new WebContentsImpl(&browser_context,
25 new TabContents(&browser_context, NULL, MSG_ROUTING_NONE, NULL, NULL)); 25 NULL,
26 scoped_ptr<TabContents> contents_b( 26 MSG_ROUTING_NONE,
27 new TabContents(&browser_context, NULL, MSG_ROUTING_NONE, NULL, NULL)); 27 NULL,
28 NULL));
29 scoped_ptr<WebContentsImpl> contents_b(new WebContentsImpl(&browser_context,
30 NULL,
31 MSG_ROUTING_NONE,
32 NULL,
33 NULL));
28 EXPECT_TRUE(contents_a->GetDelegate() == NULL); 34 EXPECT_TRUE(contents_a->GetDelegate() == NULL);
29 EXPECT_TRUE(contents_b->GetDelegate() == NULL); 35 EXPECT_TRUE(contents_b->GetDelegate() == NULL);
30 36
31 scoped_ptr<MockWebContentsDelegate> delegate(new MockWebContentsDelegate()); 37 scoped_ptr<MockWebContentsDelegate> delegate(new MockWebContentsDelegate());
32 38
33 // Setting a delegate should work correctly. 39 // Setting a delegate should work correctly.
34 contents_a->SetDelegate(delegate.get()); 40 contents_a->SetDelegate(delegate.get());
35 EXPECT_EQ(delegate.get(), contents_a->GetDelegate()); 41 EXPECT_EQ(delegate.get(), contents_a->GetDelegate());
36 EXPECT_TRUE(contents_b->GetDelegate() == NULL); 42 EXPECT_TRUE(contents_b->GetDelegate() == NULL);
37 43
38 // A delegate can be a delegate to multiple TabContents. 44 // A delegate can be a delegate to multiple WebContentsImpl.
39 contents_b->SetDelegate(delegate.get()); 45 contents_b->SetDelegate(delegate.get());
40 EXPECT_EQ(delegate.get(), contents_a->GetDelegate()); 46 EXPECT_EQ(delegate.get(), contents_a->GetDelegate());
41 EXPECT_EQ(delegate.get(), contents_b->GetDelegate()); 47 EXPECT_EQ(delegate.get(), contents_b->GetDelegate());
42 48
43 // Setting the same delegate multiple times should work correctly. 49 // Setting the same delegate multiple times should work correctly.
44 contents_b->SetDelegate(delegate.get()); 50 contents_b->SetDelegate(delegate.get());
45 EXPECT_EQ(delegate.get(), contents_a->GetDelegate()); 51 EXPECT_EQ(delegate.get(), contents_a->GetDelegate());
46 EXPECT_EQ(delegate.get(), contents_b->GetDelegate()); 52 EXPECT_EQ(delegate.get(), contents_b->GetDelegate());
47 53
48 // Setting delegate to NULL should work correctly. 54 // Setting delegate to NULL should work correctly.
49 contents_b->SetDelegate(NULL); 55 contents_b->SetDelegate(NULL);
50 EXPECT_EQ(delegate.get(), contents_a->GetDelegate()); 56 EXPECT_EQ(delegate.get(), contents_a->GetDelegate());
51 EXPECT_TRUE(contents_b->GetDelegate() == NULL); 57 EXPECT_TRUE(contents_b->GetDelegate() == NULL);
52 58
53 // Destroying the delegate while it is still the delegate 59 // Destroying the delegate while it is still the delegate
54 // for a TabContents should unregister it. 60 // for a WebContentsImpl should unregister it.
55 contents_b->SetDelegate(delegate.get()); 61 contents_b->SetDelegate(delegate.get());
56 EXPECT_EQ(delegate.get(), contents_a->GetDelegate()); 62 EXPECT_EQ(delegate.get(), contents_a->GetDelegate());
57 EXPECT_EQ(delegate.get(), contents_b->GetDelegate()); 63 EXPECT_EQ(delegate.get(), contents_b->GetDelegate());
58 delegate.reset(NULL); 64 delegate.reset(NULL);
59 EXPECT_TRUE(contents_a->GetDelegate() == NULL); 65 EXPECT_TRUE(contents_a->GetDelegate() == NULL);
60 EXPECT_TRUE(contents_b->GetDelegate() == NULL); 66 EXPECT_TRUE(contents_b->GetDelegate() == NULL);
61 67
62 // Destroy the tab contents and run the message loop to prevent leaks. 68 // Destroy the tab contents and run the message loop to prevent leaks.
63 contents_a.reset(NULL); 69 contents_a.reset(NULL);
64 contents_b.reset(NULL); 70 contents_b.reset(NULL);
65 loop.RunAllPending(); 71 loop.RunAllPending();
66 } 72 }
67 73
68 } // namespace 74 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698