Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10038026: TabContents -> WebContentsImpl, part 12. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 12. "Detab" content/browser/web_contents. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132257

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : *web*contents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -320 lines) Patch
M content/browser/ssl/ssl_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.h View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 2 19 chunks +75 lines, -71 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl.h View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 32 chunks +44 lines, -44 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/test_web_contents.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/test_web_contents.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_delegate_unittest.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 17 chunks +38 lines, -38 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 14 chunks +41 lines, -41 lines 0 comments Download
M content/browser/web_contents/web_contents_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_helper.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 17 chunks +41 lines, -41 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_win.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-13 14:21:53 UTC) #1
jam
lgtm with nits http://codereview.chromium.org/10038026/diff/1/content/browser/web_contents/interstitial_page_impl.cc File content/browser/web_contents/interstitial_page_impl.cc (right): http://codereview.chromium.org/10038026/diff/1/content/browser/web_contents/interstitial_page_impl.cc#newcode130 content/browser/web_contents/interstitial_page_impl.cc:130: static InterstitialPageMap* g_contents_to_interstitial_page; ditto http://codereview.chromium.org/10038026/diff/1/content/browser/web_contents/interstitial_page_impl.h File ...
8 years, 8 months ago (2012-04-13 18:23:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10038026/16001
8 years, 8 months ago (2012-04-13 18:58:15 UTC) #3
Avi (use Gerrit)
All done.
8 years, 8 months ago (2012-04-13 18:58:16 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 20:20:58 UTC) #5 
Change committed as 132257

Powered by Google App Engine
This is Rietveld 408576698