Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 10038011: Add FlimflamProfileClientTest (Closed)

Created:
8 years, 8 months ago by hashimoto
Modified:
8 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add FlimflamProfileClientTest BUG=chromium-os:16557 TEST=chromeos_unittests --gtest_filter="FlimflamProfileClientTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132513

Patch Set 1 : _ #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Fixed a nit #

Patch Set 4 : Fix merge error #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -9 lines) Patch
M chromeos/chromeos.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/flimflam_client_unittest_base.h View 2 chunks +4 lines, -1 line 0 comments Download
M chromeos/dbus/flimflam_client_unittest_base.cc View 1 2 5 chunks +13 lines, -6 lines 0 comments Download
M chromeos/dbus/flimflam_manager_client_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/dbus/flimflam_network_client_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A chromeos/dbus/flimflam_profile_client_unittest.cc View 1 2 3 1 chunk +160 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
This change depends on http://codereview.chromium.org/9958045/
8 years, 8 months ago (2012-04-12 11:46:52 UTC) #1
stevenjb
lgtm w/ nit http://codereview.chromium.org/10038011/diff/14/chromeos/dbus/flimflam_client_unittest_base.cc File chromeos/dbus/flimflam_client_unittest_base.cc (right): http://codereview.chromium.org/10038011/diff/14/chromeos/dbus/flimflam_client_unittest_base.cc#newcode24 chromeos/dbus/flimflam_client_unittest_base.cc:24: const dbus::ObjectPath& object_path) : interface_name_(interface_name), nit: ...
8 years, 8 months ago (2012-04-12 17:38:30 UTC) #2
hashimoto
http://codereview.chromium.org/10038011/diff/14/chromeos/dbus/flimflam_client_unittest_base.cc File chromeos/dbus/flimflam_client_unittest_base.cc (right): http://codereview.chromium.org/10038011/diff/14/chromeos/dbus/flimflam_client_unittest_base.cc#newcode24 chromeos/dbus/flimflam_client_unittest_base.cc:24: const dbus::ObjectPath& object_path) : interface_name_(interface_name), On 2012/04/12 17:38:30, stevenjb ...
8 years, 8 months ago (2012-04-13 06:31:14 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 01:53:41 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698