Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 10037023: Enable UserDataDir selection in InProcessBrowserTest (Closed)

Created:
8 years, 8 months ago by Devlin
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Yoyo Zhou
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable UserDataDir selection in InProcessBrowserTest Changed InProcessBrowserTest to allow us to use SetUpCommandLine to specify a UserDataDir via the kUserDataDir switch. It appears this was intended in the original code, since CreateUserDataDirectory currently checks the commandline for the presence of kUserDataDir. BUG=122883 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132347

Patch Set 1 #

Patch Set 2 : Fixed issues with tests using InProcessBrowserTest #

Total comments: 3

Patch Set 3 : Updated to latest master branch #

Patch Set 4 : Updated to latest master branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M chrome/browser/extensions/extension_browsertest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 chunks +21 lines, -19 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Devlin
Quick fix to allow kUserDataDir to work in InProcessBrowserTest; passes win_rel, linux_rel, and mac_rel.
8 years, 8 months ago (2012-04-11 23:42:45 UTC) #1
Yoyo Zhou
https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/extensions/extension_browsertest.h File chrome/browser/extensions/extension_browsertest.h (right): https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/extensions/extension_browsertest.h#newcode31 chrome/browser/extensions/extension_browsertest.h:31: virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE; SetUpUserDataDirectory should be here ...
8 years, 8 months ago (2012-04-12 00:25:28 UTC) #2
Devlin
https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/extensions/extension_browsertest.h File chrome/browser/extensions/extension_browsertest.h (right): https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/extensions/extension_browsertest.h#newcode31 chrome/browser/extensions/extension_browsertest.h:31: virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE; On 2012/04/12 00:25:28, Yoyo ...
8 years, 8 months ago (2012-04-12 00:37:10 UTC) #3
Yoyo Zhou
LGTM but you might want a sanity check from Aaron too. https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/extensions/extension_browsertest.h File chrome/browser/extensions/extension_browsertest.h (right): ...
8 years, 8 months ago (2012-04-12 00:45:02 UTC) #4
Aaron Boodman
LGTM
8 years, 8 months ago (2012-04-12 04:27:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10037023/11001
8 years, 8 months ago (2012-04-13 23:32:18 UTC) #6
commit-bot: I haz the power
Try job failure for 10037023-11001 (retry) (retry) on mac_rel for step "compile" (clobber build). It's ...
8 years, 8 months ago (2012-04-14 01:20:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10037023/11001
8 years, 8 months ago (2012-04-14 16:52:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10037023/17001
8 years, 8 months ago (2012-04-14 16:54:46 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 19:22:47 UTC) #10
Change committed as 132347

Powered by Google App Engine
This is Rietveld 408576698