Issue 10037007: Fixing: fake asan run time for pyauto must be built without asan itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10037007: Fixing: fake asan run time for pyauto must be built without asan itself (Closed)

Created:
8 years, 8 months ago by glotov

Modified:
8 years, 8 months ago

Reviewers:
kcc2, Alexander Potapenko, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing: fake asan run time for pyauto must be built without asan itself BUG=chromium-os:24567 TEST='USE="asan clang build_tests" emerge-x86-generic chromeos-chrome' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131614

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/chrome_tests.gypi	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

On 2012/04/10 16:44:36, glotov wrote: > Hi! Please have a look. lgtm

8 years, 8 months ago (2012-04-10 17:47:25 UTC) #2

Nico

lgtm if it's ok that this doesn't do anything on mac. http://codereview.chromium.org/10037007/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): ...

8 years, 8 months ago (2012-04-10 17:49:54 UTC) #3

glotov

8 years, 8 months ago (2012-04-10 20:02:34 UTC) #4

That;s alright, we don't build cros for mac. But I'll have in mind.
Thanks for the review.

On 2012/04/10 17:49:54, Nico wrote:
> lgtm if it's ok that this doesn't do anything on mac.
> 
> http://codereview.chromium.org/10037007/diff/1/chrome/chrome_tests.gypi
> File chrome/chrome_tests.gypi (right):
> 
>
http://codereview.chromium.org/10037007/diff/1/chrome/chrome_tests.gypi#newco...
> chrome/chrome_tests.gypi:4452: 'cflags!': [ '-faddress-sanitizer' ],
> This doesn't remove the flag for mac (which uses something below
xcode_settings,
> probably OTHER_CFLAGS.

Expand Messages | Collapse Messages