Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: content/browser/renderer_host/media/media_stream_device_settings.h

Issue 10035054: Merge VideoCaptureDevice::Capability with media::VideoCaptureCapability (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix a namespace issue Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/media/video_capture_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/media_stream_device_settings.h
diff --git a/content/browser/renderer_host/media/media_stream_device_settings.h b/content/browser/renderer_host/media/media_stream_device_settings.h
index 0a83cda550d09845b8634ffdd2d98d7495888c3c..a42fa50327d86dc0aee61d90c0e7a57a90822b43 100644
--- a/content/browser/renderer_host/media/media_stream_device_settings.h
+++ b/content/browser/renderer_host/media/media_stream_device_settings.h
@@ -7,21 +7,13 @@
// There will be one instance of MediaStreamDeviceSettings handling all
// requests.
-// This version always accepts the first device in the list(s), but this will
-// soon be changed to ask the user and/or Chrome settings.
-
// Expected call flow:
-// 1. RequestCaptureDeviceUsage() to request usage of capture device.
-// 2. SettingsRequester::GetDevices() is called to get a list of available
-// devices.
-// 3. AvailableDevices() is called with a list of currently available devices.
-// 4. TODO(mflodman) Pick device and get user confirmation.
-// Temporary 4. Choose first device of each requested media type.
-// 5. Confirm by calling SettingsRequester::DevicesAccepted().
-// Repeat step 1 - 5 for new device requests.
-
-// Note that this is still in a development phase and the class will be modified
-// to include real UI interaction.
+// 1. RequestCaptureDeviceUsage() is called to create a new request for capture
+// device usage.
+// 2. AvailableDevices() is called with a list of currently available devices.
+// 3. Pick device and get user confirmation.
+// 4. Confirm by calling SettingsRequester::DevicesAccepted().
+// Repeat step 1 - 4 for new device requests.
#ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_DEVICE_SETTINGS_H_
#define CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_DEVICE_SETTINGS_H_
@@ -72,7 +64,7 @@ class CONTENT_EXPORT MediaStreamDeviceSettings
void UseFakeUI();
private:
- typedef std::map< std::string, MediaStreamDeviceSettingsRequest* >
+ typedef std::map<std::string, MediaStreamDeviceSettingsRequest*>
SettingsRequests;
SettingsRequester* requester_;
« no previous file with comments | « no previous file | content/browser/renderer_host/media/video_capture_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698