Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 10035054: Merge VideoCaptureDevice::Capability with media::VideoCaptureCapability (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebased code and addressed scherkus's comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_controller.cc
diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc
index d4ad734acd3a1c61ef946344a0d6490ff5618a05..0444f97a6aee394eb618d0291be23658349b525c 100644
--- a/content/browser/renderer_host/media/video_capture_controller.cc
+++ b/content/browser/renderer_host/media/video_capture_controller.cc
@@ -288,13 +288,13 @@ void VideoCaptureController::OnIncomingCapturedFrame(const uint8* data,
// Do color conversion from the camera format to I420.
switch (frame_info_.color) {
- case media::VideoCaptureDevice::kColorUnknown: // Color format not set.
+ case media::VideoCaptureCapability::kColorUnknown: // Color format not set.
break;
- case media::VideoCaptureDevice::kI420: {
+ case media::VideoCaptureCapability::kI420: {
memcpy(target, data, (frame_info_.width * frame_info_.height * 3) / 2);
break;
}
- case media::VideoCaptureDevice::kYV12: {
+ case media::VideoCaptureCapability::kYV12: {
const uint8* ptr = data;
memcpy(yplane, ptr, (frame_info_.width * frame_info_.height));
ptr += frame_info_.width * frame_info_.height;
@@ -303,17 +303,17 @@ void VideoCaptureController::OnIncomingCapturedFrame(const uint8* data,
memcpy(uplane, ptr, (frame_info_.width * frame_info_.height) >> 2);
break;
}
- case media::VideoCaptureDevice::kNV21: {
+ case media::VideoCaptureCapability::kNV21: {
media::ConvertNV21ToYUV(data, yplane, uplane, vplane, frame_info_.width,
frame_info_.height);
break;
}
- case media::VideoCaptureDevice::kYUY2: {
+ case media::VideoCaptureCapability::kYUY2: {
media::ConvertYUY2ToYUV(data, yplane, uplane, vplane, frame_info_.width,
frame_info_.height);
break;
}
- case media::VideoCaptureDevice::kRGB24: {
+ case media::VideoCaptureCapability::kRGB24: {
int ystride = frame_info_.width;
int uvstride = frame_info_.width / 2;
#if defined(OS_WIN) // RGB on Windows start at the bottom line.
@@ -329,7 +329,7 @@ void VideoCaptureController::OnIncomingCapturedFrame(const uint8* data,
rgb_stride, ystride, uvstride);
break;
}
- case media::VideoCaptureDevice::kARGB: {
+ case media::VideoCaptureCapability::kARGB: {
media::ConvertRGB32ToYUV(data, yplane, uplane, vplane, frame_info_.width,
frame_info_.height, frame_info_.width * 4,
frame_info_.width, frame_info_.width / 2);
@@ -353,7 +353,7 @@ void VideoCaptureController::OnError() {
}
void VideoCaptureController::OnFrameInfo(
- const media::VideoCaptureDevice::Capability& info) {
+ const media::VideoCaptureCapability& info) {
frame_info_= info;
BrowserThread::PostTask(BrowserThread::IO,
FROM_HERE,
@@ -399,7 +399,7 @@ void VideoCaptureController::DoErrorOnIOThread() {
}
void VideoCaptureController::DoFrameInfoOnIOThread(
- const media::VideoCaptureDevice::Capability info) {
+ const media::VideoCaptureCapability info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DCHECK(owned_dibs_.empty())
<< "Device is restarted without releasing shared memory.";

Powered by Google App Engine
This is Rietveld 408576698