chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc - Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

diff --git a/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc b/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

index ddb07621e8f4ad304dd652db5c252d1b38a855f0..a32a22f5fde09f30c4c73d4b0507dfa47d751e4b 100644

--- a/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

+++ b/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

@@ -99,8 +99,7 @@ void TabModalConfirmDialogWebUI::OnDialogClosed(

const std::string& json_retval) {

bool accepted = false;

if (!json_retval.empty()) {

- base::JSONReader reader;

- scoped_ptr<Value> value(reader.JsonToValue(json_retval, false, false));

+ scoped_ptr<Value> value(base::JSONReader::Read(json_retval));

if (!value.get() || !value->GetAsBoolean(&accepted))

NOTREACHED() << "Missing or unreadable response from dialog";

}

« no previous file with comments | « chrome/browser/prefs/pref_model_associator.cc ('k') | chrome/common/extensions/api/extension_api.cc » ('j') | no next file with comments »