base/string_util.cc - Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_util.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/string_util.cc

diff --git a/base/string_util.cc b/base/string_util.cc

index 2b9e1bcda47743f7a823954442799e7d9b345af7..d2b52c3e1f535b3f148d75c929f03f5b39d730a1 100644

--- a/base/string_util.cc

+++ b/base/string_util.cc

@@ -476,7 +476,7 @@ bool IsStringUTF8(const std::string& str) {

int32 code_point;

CBU8_NEXT(src, char_index, src_len, code_point);

if (!base::IsValidCharacter(code_point))

- return false;

+ return false;

}

return true;

}

« no previous file with comments | « base/json/json_reader_unittest.cc ('k') | base/values.h » ('j') | no next file with comments »