Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4104)

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments/fix Win Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api.cc
diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc
index 97e7e11ef9288e5083ae9b2b29588e98725bc10c..2d17a0b2abac4fc9fe1c3ed49b35d1c2005304bb 100644
--- a/chrome/common/extensions/api/extension_api.cc
+++ b/chrome/common/extensions/api/extension_api.cc
@@ -70,7 +70,7 @@ scoped_ptr<ListValue> LoadSchemaList(const std::string& name,
scoped_ptr<Value> result(
base::JSONReader::ReadAndReturnError(
schema.as_string(),
- base::JSON_PARSE_RFC, // options
+ base::JSON_PARSE_RFC | base::JSON_DETACHABLE_CHILDREN, // options
NULL, // error code
&error_message));

Powered by Google App Engine
This is Rietveld 408576698