chrome/common/extensions/api/extension_api.cc - Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/json/json_parser_unittest.cc ('K') | « chrome/browser/prefs/pref_model_associator.cc ('k') | chrome/common/extensions/extension_l10n_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_api.cc

diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc

index bdccc9b7ce2347bd9461f1f56408229147f0a591..53162f7b69c5c6dc2b7fdb36f538dcf2219a6ca2 100644

--- a/chrome/common/extensions/api/extension_api.cc

+++ b/chrome/common/extensions/api/extension_api.cc

@@ -69,7 +69,7 @@ scoped_ptr<ListValue> LoadSchemaList(const base::StringPiece& schema) {

scoped_ptr<Value> result(

base::JSONReader::ReadAndReturnError(

schema.as_string(),

- base::JSON_PARSE_RFC, // options

+ base::JSON_PARSE_RFC | base::JSON_DETACHABLE_CHILDREN, // options

NULL, // error code

&error_message));

CHECK(result.get()) << error_message;

« base/json/json_parser_unittest.cc ('K') | « chrome/browser/prefs/pref_model_associator.cc ('k') | chrome/common/extensions/extension_l10n_util_unittest.cc » ('j') | no next file with comments »