Fix accelerated content in fullscreen in 10.6.

Fix accelerated content in fullscreen in 10.6.

BUG=123699, 53382, 56154, 120772
TEST=as in bug 123699


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132840

[Avi (use Gerrit), 2012-04-18 15:52:25]

The change is making sure -[NSWindow setOpaque:NO] is always called on >10.5;
the rest is just shuffling things around.

[Robert Sesek, 2012-04-18 15:53:41]

Nico is a better reviewer for this.

[Nico, 2012-04-18 16:08:34]

https://chromiumcodereview.appspot.com/10035029/diff/1/ui/base/cocoa/underlay...
File ui/base/cocoa/underlay_opengl_hosting_window.mm (right):

https://chromiumcodereview.appspot.com/10035029/diff/1/ui/base/cocoa/underlay...
ui/base/cocoa/underlay_opengl_hosting_window.mm:114: if (windowStyle &&
NSTitledWindowMask) {
you mean '&', not '&&', right? (did clang not warn about this?)

[Avi (use Gerrit), 2012-04-18 16:14:48]

ptal

https://chromiumcodereview.appspot.com/10035029/diff/1/ui/base/cocoa/underlay...
File ui/base/cocoa/underlay_opengl_hosting_window.mm (right):

https://chromiumcodereview.appspot.com/10035029/diff/1/ui/base/cocoa/underlay...
ui/base/cocoa/underlay_opengl_hosting_window.mm:114: if (windowStyle &&
NSTitledWindowMask) {
On 2012/04/18 16:08:34, Nico wrote:
> you mean '&', not '&&', right? (did clang not warn about this?)

Aaaaaaaaaa

[Nico, 2012-04-18 16:15:38]

LGTM

Please test extensions bubbles before landing ;-)

[Avi (use Gerrit), 2012-04-18 16:16:24]

On 2012/04/18 16:15:38, Nico wrote:
> LGTM
> 
> Please test extensions bubbles before landing ;-)

That was tested and works.

[commit-bot: I haz the power, 2012-04-18 16:16:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10035029/5001

[Nico, 2012-04-18 16:23:26]

> (did clang not warn about this?)

Answering my own question: clang warns on `var && const` if const is not 0 or 1.
NSTitledWindowMask is defined as |1 << 0|, hence no warning in this case :-(

[Avi (use Gerrit), 2012-04-18 16:27:08]

On 2012/04/18 16:23:26, Nico wrote:
> > (did clang not warn about this?)
> 
> Answering my own question: clang warns on `var && const` if const is not 0 or
1.
> NSTitledWindowMask is defined as |1 << 0|, hence no warning in this case :-(

And this seemed to work because the callers were using NSBorderlessWindowMask,
which is 0.

[commit-bot: I haz the power, 2012-04-18 19:21:17]

Change committed as 132840