Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10035017: Updated media player resources with new images from Ken Moore. (Closed)

Created:
8 years, 8 months ago by nessy
Modified:
8 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Updated media player resources with new images from Ken Moore. This CL contains some new and updated assets for the media controls. BUG=88489 TEST=None needed. Purely asset additions.

Patch Set 1 #

Patch Set 2 : test uploading updated media player resource binaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-12 lines, --25 lines) Patch
A webkit/glue/resources/mediaplayer_fullscreen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_fullscreen_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_fullscreen_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_fullscreen_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_pause.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_pause_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_pause_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_play.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_play_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_play_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_play_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_slider_thumb.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_slider_thumb_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_slider_thumb_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_disabled_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_disabled_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/resources/mediaplayer_sound_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/resources/mediaplayer_sound_full_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/resources/mediaplayer_sound_full_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_level0.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_level0_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_level0_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level1.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level1_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level1_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level2.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level2_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level2_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_level3.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_level3_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_sound_level3_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/resources/mediaplayer_sound_none.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/resources/mediaplayer_sound_none_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/resources/mediaplayer_sound_none_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_volume_slider_thumb.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/mediaplayer_volume_slider_thumb_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_volume_slider_thumb_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_volume_slider_thumb_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/webkit_resources.grd View 1 chunk +12 lines, -7 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 3 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nessy
First patch for the updated video controls.
8 years, 8 months ago (2012-04-18 00:56:52 UTC) #1
scherkus (not reviewing)
did you (or someone else) run a tool like pngcrush on these pngs? other than ...
8 years, 8 months ago (2012-04-19 00:56:35 UTC) #2
nessy
On 2012/04/19 00:56:35, scherkus wrote: > did you (or someone else) run a tool like ...
8 years, 8 months ago (2012-04-19 10:12:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/silviapf@chromium.org/10035017/1
8 years, 8 months ago (2012-04-20 03:21:59 UTC) #4
commit-bot: I haz the power
Presubmit check for 10035017-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-20 03:22:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/silviapf@chromium.org/10035017/1
8 years, 8 months ago (2012-04-20 06:53:20 UTC) #6
commit-bot: I haz the power
Presubmit check for 10035017-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-20 06:53:42 UTC) #7
jamesr
LGTM TBR would be appropriate for something like this
8 years, 8 months ago (2012-04-23 22:24:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/silviapf@chromium.org/10035017/1
8 years, 8 months ago (2012-04-23 23:02:26 UTC) #9
commit-bot: I haz the power
Try job failure for 10035017-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-23 23:37:11 UTC) #10
scherkus (not reviewing)
8 years, 8 months ago (2012-04-25 22:38:45 UTC) #11
Committed as r133966.

Powered by Google App Engine
This is Rietveld 408576698