third_party/tcmalloc/chromium/src/thread_cache.h - Issue 10035012: Added compile-time define to add "initial-exec" attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/thread_cache.h

Issue 10035012: Added compile-time define to add "initial-exec" attribute. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Made the comments better. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/tcmalloc/chromium/src/thread_cache.h

diff --git a/third_party/tcmalloc/chromium/src/thread_cache.h b/third_party/tcmalloc/chromium/src/thread_cache.h

index 529402908450e9efb3f06708cdbd6dbecc7c7236..a5de126ff33c18e46af81170030e67568dade44c 100644

--- a/third_party/tcmalloc/chromium/src/thread_cache.h

+++ b/third_party/tcmalloc/chromium/src/thread_cache.h

@@ -259,7 +259,9 @@ class ThreadCache {

// a good tradeoff for us.

#ifdef HAVE_TLS

static __thread ThreadCache* threadlocal_heap_

-# ifdef HAVE___ATTRIBUTE__

+ // See comments in the header file about this #define. Bug here:

gpike 2012/04/24 20:49:29 s/the header file/thread_cache.cc/ s/ #define//

asharif1 2012/04/24 21:02:34 Good catch. This is the header file. I will switch

+ // http://code.google.com/p/chromium/issues/detail?id=124489

+#if defined(HAVE___ATTRIBUTE__) && !defined(PGO_GENERATE)

__attribute__ ((tls_model ("initial-exec")))

# endif

;

« no previous file with comments | « no previous file | third_party/tcmalloc/chromium/src/thread_cache.cc » ('j') | no next file with comments »