Fixed pageActions.enableForTab

Fixed pageActions.enableForTab

pageActions.enableForTab was using the same framework as the newer pageAction
API, which expects a tab ID for the first argument.

BUG=122833
TEST=Load the extension from the bug.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132321

[cduvall, 2012-04-11 23:47:26]

Fixed the issue with pageActions.enableForTab.

[Aaron Boodman, 2012-04-13 22:52:52]

lgtm

http://codereview.chromium.org/10034037/diff/1/chrome/browser/extensions/api/...
File
chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc
(right):

http://codereview.chromium.org/10034037/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc:138:
PageActionsFunction::PageActionsFunction() {
can you move the constructor and destructor impls up above the first method?

[commit-bot: I haz the power, 2012-04-13 22:58:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cduvall@chromium.org/10034037/5002

[cduvall, 2012-04-13 22:59:19]

Thanks!

http://codereview.chromium.org/10034037/diff/1/chrome/browser/extensions/api/...
File
chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc
(right):

http://codereview.chromium.org/10034037/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc:138:
PageActionsFunction::PageActionsFunction() {
On 2012/04/13 22:52:52, Aaron Boodman wrote:
> can you move the constructor and destructor impls up above the first method?

Done.

[commit-bot: I haz the power, 2012-04-14 00:50:00]

Try job failure for 10034037-5002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-14 00:51:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cduvall@chromium.org/10034037/5002

[commit-bot: I haz the power, 2012-04-14 03:29:25]

Change committed as 132321