Changed some int casts to intptr_t.

src/objects.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 777 matching lines @@
   // Casting.
   static inline Smi* cast(Object* object);
 
   // Dispatched behavior.
   void SmiPrint();
   void SmiPrint(StringStream* accumulator);
 #ifdef DEBUG
   void SmiVerify();
 #endif
 
+  static const int kSmiPrecission = 31;
   // Min and max limits for Smi values.
-  static const int kMinValue = -(1 << (kBitsPerPointer - (kSmiTagSize + 1)));
-  static const int kMaxValue = (1 << (kBitsPerPointer - (kSmiTagSize + 1))) - 1;
+  static const int kMinValue = -(1 << (kSmiPrecission - (kSmiTagSize)));
+  static const int kMaxValue = (1 << (kSmiPrecission - (kSmiTagSize))) - 1;

[Dean McNamee, 2009/05/04 13:04:14]

I would call this kSmiNumBits, precision (spelling) doesn't really make it clear
that it's the number of bits.

 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(Smi);
 };
 
 
 // Failure is used for reporting out of memory situations and
 // propagating exceptions through the runtime system.  Failure objects
 // are transient and cannot occur as part of the objects graph.
 //
@@ skipping 1506 matching lines @@
   static int SizeFor(int body_size, int sinfo_size) {
     ASSERT_SIZE_TAG_ALIGNED(body_size);
     ASSERT_SIZE_TAG_ALIGNED(sinfo_size);
     return RoundUp(kHeaderSize + body_size + sinfo_size, kCodeAlignment);
   }
 
   // Calculate the size of the code object to report for log events. This takes
   // the layout of the code object into account.
   int ExecutableSize() {
     // Check that the assumptions about the layout of the code object holds.
-    ASSERT_EQ(reinterpret_cast<unsigned int>(instruction_start()) -
-              reinterpret_cast<unsigned int>(address()),
+    ASSERT_EQ(reinterpret_cast<uintptr_t>(instruction_start()) -
+              reinterpret_cast<uintptr_t>(address()),

[Dean McNamee, 2009/05/04 13:04:14]

Do we really need this, both should be returning pointers, instruction_start
returns a byte*, and address returns an Address (which is also a byte*).  Is
there something about subtracting pointers I'm missing?

               Code::kHeaderSize);
     return instruction_size() + Code::kHeaderSize;
   }
 
   // Locating source position.
   int SourcePosition(Address pc);
   int SourceStatementPosition(Address pc);
 
   // Casting.
   static inline Code* cast(Object* obj);
@@ skipping 2029 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_