Issue 100335: Fix http://code.google.com/p/chromium/issues/detail?id=1717...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100335: Fix http://code.google.com/p/chromium/issues/detail?id=1717... (Closed)

Created:
11 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix http://code.google.com/p/chromium/issues/detail?id=1717 undeletable functions on some prototypes. Committed: http://code.google.com/p/v8/source/detail?r=1842

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -10 lines)			Patch
M	src/array.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/date-delay.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/math.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/string.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	test/mjsunit/undeletable-functions.js	View	1 chunk	+144 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 7 months ago (2009-05-04 12:20:31 UTC) #2

Unfortunately, for compatibility this LGTM.

http://codereview.chromium.org/100335/diff/1/2
File test/mjsunit/undeletable-functions.js (right):

http://codereview.chromium.org/100335/diff/1/2#newcode1
Line 1: var array;
Copyright header and a description of the "problem"?

Expand Messages | Collapse Messages