Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/search_engines/template_url_parser.cc

Issue 10033017: More misc. cleanups to minimize future refactoring diffs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/search_engines/search_provider_install_data.cc ('K') | « chrome/browser/search_engines/template_url_fetcher_unittest.cc ('k') | chrome/browser/search_engines/template_url_service.h » ('j') | chrome/browser/search_engines/template_url_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_parser.cc
===================================================================
--- chrome/browser/search_engines/template_url_parser.cc (revision 131375)
+++ chrome/browser/search_engines/template_url_parser.cc (working copy)
@@ -99,8 +99,8 @@
if (url.empty())
return true;
GURL gurl(url);
- return (gurl.is_valid() && (gurl.SchemeIs(chrome::kHttpScheme) ||
- gurl.SchemeIs(chrome::kHttpsScheme)));
+ return gurl.is_valid() && (gurl.SchemeIs(chrome::kHttpScheme) ||
+ gurl.SchemeIs(chrome::kHttpsScheme));
}
} // namespace
@@ -312,7 +312,6 @@
if (suggestion_method_ == TemplateURLParsingContext::POST)
data_.suggestions_url.clear();
- // Give this a keyword to facilitate tab-to-search.
string16 keyword(TemplateURLService::GenerateKeyword(url, false));
DCHECK(!keyword.empty());
data_.SetKeyword(keyword);
« chrome/browser/search_engines/search_provider_install_data.cc ('K') | « chrome/browser/search_engines/template_url_fetcher_unittest.cc ('k') | chrome/browser/search_engines/template_url_service.h » ('j') | chrome/browser/search_engines/template_url_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698