Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc

Issue 10033015: Fix ProcessOutputWatcherTest.OutputWatcher under ASAN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove extra line Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc
diff --git a/chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc b/chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc
index 778e905bdc2c50bb0e25e4b83b3ed2ce455a4455..acb65173daf1a129964c044ff8f0fb0cd795f200 100644
--- a/chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc
+++ b/chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc
@@ -125,8 +125,10 @@ TEST_F(ProcessOutputWatcherTest, OutputWatcher) {
test_cases.push_back(TestCase("testing output3\n", PROCESS_OUTPUT_TYPE_OUT));
test_cases.push_back(TestCase(VeryLongString(), PROCESS_OUTPUT_TYPE_OUT));
test_cases.push_back(TestCase("testing error2\n", PROCESS_OUTPUT_TYPE_OUT));
- test_cases.push_back(TestCase("line with \0 in it\n",
- arraysize("line with \0 in it \n"),
+
+ char line_with_null_char[] = "line with \0 in it\n";
+ test_cases.push_back(TestCase(line_with_null_char,
+ arraysize(line_with_null_char) - 1,
oshima 2012/04/10 00:58:12 Maybe I'm dumb, but sorry I didn't understand why
tonibarzic 2012/04/10 01:16:59 I don't necessary need -1, but it's more in line w
PROCESS_OUTPUT_TYPE_OUT));
output_watch_thread.message_loop()->PostTask(FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698