Issue 100330: Removed long-running array sort test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100330: Removed long-running array sort test. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Removed long-running array sort test. Long running array-sort test times out on ARM. Also fixed a bug in another test.

Patch Set 1 #

Total comments: 4

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	test/mjsunit/array-sort.js	View		7 chunks	+12 lines, -10 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/100330/diff/1/2 File test/mjsunit/array-sort.js (left): http://codereview.chromium.org/100330/diff/1/2#oldcode334 Line 334: assertFalse(x.hasOwnProperty(11), name + "hasundefined11"); Is what this ...

11 years, 7 months ago (2009-05-04 08:55:21 UTC) #3

Lasse Reichstein

11 years, 7 months ago (2009-05-04 09:07:07 UTC) #4

http://codereview.chromium.org/100330/diff/1/2
File test/mjsunit/array-sort.js (left):

http://codereview.chromium.org/100330/diff/1/2#oldcode334
Line 334: assertFalse(x.hasOwnProperty(11), name + "hasundefined11");
Yes. It's the sorted.length test above (11 should have been 12).

Expand Messages | Collapse Messages