Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 10032029: Eliminate redundant array bound checks (checks already performed earlier in the DT). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed style issues and shortened the phase name to help Golem understand it. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 590 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 if (next != NULL) next->previous_ = this; 601 if (next != NULL) next->previous_ = this;
602 } 602 }
603 603
604 604
605 #ifdef DEBUG 605 #ifdef DEBUG
606 void HInstruction::Verify() { 606 void HInstruction::Verify() {
607 // Verify that input operands are defined before use. 607 // Verify that input operands are defined before use.
608 HBasicBlock* cur_block = block(); 608 HBasicBlock* cur_block = block();
609 for (int i = 0; i < OperandCount(); ++i) { 609 for (int i = 0; i < OperandCount(); ++i) {
610 HValue* other_operand = OperandAt(i); 610 HValue* other_operand = OperandAt(i);
611 if (other_operand == NULL) continue;
611 HBasicBlock* other_block = other_operand->block(); 612 HBasicBlock* other_block = other_operand->block();
612 if (cur_block == other_block) { 613 if (cur_block == other_block) {
613 if (!other_operand->IsPhi()) { 614 if (!other_operand->IsPhi()) {
614 HInstruction* cur = this->previous(); 615 HInstruction* cur = this->previous();
615 while (cur != NULL) { 616 while (cur != NULL) {
616 if (cur == other_operand) break; 617 if (cur == other_operand) break;
617 cur = cur->previous(); 618 cur = cur->previous();
618 } 619 }
619 // Must reach other operand in the same block! 620 // Must reach other operand in the same block!
620 ASSERT(cur == other_operand); 621 ASSERT(cur == other_operand);
(...skipping 1713 matching lines...) Expand 10 before | Expand all | Expand 10 after
2334 2335
2335 2336
2336 void HCheckPrototypeMaps::Verify() { 2337 void HCheckPrototypeMaps::Verify() {
2337 HInstruction::Verify(); 2338 HInstruction::Verify();
2338 ASSERT(HasNoUses()); 2339 ASSERT(HasNoUses());
2339 } 2340 }
2340 2341
2341 #endif 2342 #endif
2342 2343
2343 } } // namespace v8::internal 2344 } } // namespace v8::internal
OLDNEW
« src/hydrogen.cc ('K') | « src/hydrogen.cc ('k') | src/v8-counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698