Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 10032020: [settings] remove unused strings bindings (Closed)

Created:
8 years, 8 months ago by Evan Stade
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[settings] remove unused string bindings in a second pass I will remove the strings themselves BUG=122251 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132150

Patch Set 1 #

Patch Set 2 : . #

Messages

Total messages: 10 (0 generated)
Evan Stade
csilv: browser_options_handler2.cc, clear_browser_data_handler2.cc, content_settings_handler2.cc, language_options_handler_common2.cc, password_manager_handler2.cc, search_engine_manager_handler2.cc mattm: certificate_manager_handler2.cc tbreisacher: home_page_overlay_handler2.cc dbeam: sync_setup_handler.cc
8 years, 8 months ago (2012-04-10 01:05:07 UTC) #1
Evan Stade
csilv: browser_options_handler2.cc, clear_browser_data_handler2.cc, content_settings_handler2.cc, language_options_handler_common2.cc, password_manager_handler2.cc, search_engine_manager_handler2.cc mattm: certificate_manager_handler2.cc tbreisacher: home_page_overlay_handler2.cc dbeam: sync_setup_handler.cc
8 years, 8 months ago (2012-04-10 02:13:45 UTC) #2
mattm
certificate_manager_handler2.cc lgtm.
8 years, 8 months ago (2012-04-10 02:15:50 UTC) #3
Tyler Breisacher (Chromium)
home_page_overlay_handler2.cc lgtm
8 years, 8 months ago (2012-04-10 02:17:22 UTC) #4
Dan Beam
sync_setup_handler.cc LGTM
8 years, 8 months ago (2012-04-10 04:11:38 UTC) #5
csilv
lgtm
8 years, 8 months ago (2012-04-10 22:57:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10032020/1010
8 years, 8 months ago (2012-04-13 01:18:29 UTC) #7
commit-bot: I haz the power
Try job failure for 10032020-1010 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-13 02:22:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10032020/1010
8 years, 8 months ago (2012-04-13 03:38:24 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 06:36:29 UTC) #10
Change committed as 132150

Powered by Google App Engine
This is Rietveld 408576698