Issue 100296: Merge r14158....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100296: Merge r14158.... (Closed)

Created:
11 years, 7 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
xji

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/

Visibility:
Public.

Description

Merge r14158. This CL fixes issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse and issue 8686 - RTL: Can't select RTL text from Chrome UI boxes The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout). The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605 BUG=6125 BUG=8686 TBR= xji Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15136

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -24 lines)			Patch
	MM	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View		2 chunks	+36 lines, -13 lines	0 comments	Download
	MM	chrome/views/controls/text_field.cc	View		2 chunks	+35 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xji

11 years, 7 months ago (2009-05-04 17:08:22 UTC) #2

LGTM, sorry for the late reply.

On 2009/05/02 06:45:55, Mark Larson wrote:
>

Expand Messages | Collapse Messages