chrome/browser/chromeos/input_method/ refactoring [part 5 of 6]

chrome/browser/chromeos/input_method/ refactoring [part 5 of 6].

Make chrome/browser/chromeos/preferences.cc unit-testable. Actual tests will be added in part 6 (http://codereview.chromium.org/9999018/).

* Split Preferences::Init() into two parts: preference members initialization and the rest. unit_tests will only need the former.
* Add Preferences::SetInputMethodList() which correctly sets the user's preferred keyboard layouts and/or input methods on signing in. The new method also sets the correct keyboard when Chrome crashes and resumes. The next CL (part 6) has a unit test for the new function.

BUG=chromium-os:19655
TEST=try


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131966

[kinaba, 2012-04-12 06:02:01]

LGTM, with just one question that perhaps doesn't matter.

http://codereview.chromium.org/10027008/diff/4001/chrome/browser/chromeos/pre...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/10027008/diff/4001/chrome/browser/chromeos/pre...
chrome/browser/chromeos/preferences.cc:703:
input_method::InputMethodManager::GetInstance();
Just for confirmation, shouldn't this be replaced with the input_method_manager_
member variable? (Perhaps not, since this part is removed in the 6/6 CL.)

[Yusuke Sato, 2012-04-12 09:21:25]

http://codereview.chromium.org/10027008/diff/4001/chrome/browser/chromeos/pre...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/10027008/diff/4001/chrome/browser/chromeos/pre...
chrome/browser/chromeos/preferences.cc:703:
input_method::InputMethodManager::GetInstance();
good point, but actually the method is static. let me keep this as-is.

On 2012/04/12 06:02:01, kinaba wrote:
> Just for confirmation, shouldn't this be replaced with the
input_method_manager_
> member variable? (Perhaps not, since this part is removed in the 6/6 CL.)

[commit-bot: I haz the power, 2012-04-12 09:27:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10027008/4001

[commit-bot: I haz the power, 2012-04-12 12:07:51]

Change committed as 131966