Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: webkit/glue/devtools/debugger_agent_impl.h

Issue 100261: DevTools: Fix access violation (null pointer) on document tear down. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/glue/devtools/debugger_agent_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_DEVTOOLS_DEBUGGER_AGENT_IMPL_H_ 5 #ifndef WEBKIT_GLUE_DEVTOOLS_DEBUGGER_AGENT_IMPL_H_
6 #define WEBKIT_GLUE_DEVTOOLS_DEBUGGER_AGENT_IMPL_H_ 6 #define WEBKIT_GLUE_DEVTOOLS_DEBUGGER_AGENT_IMPL_H_
7 7
8 #include <wtf/HashSet.h> 8 #include <wtf/HashSet.h>
9 9
10 #include "v8.h" 10 #include "v8.h"
(...skipping 11 matching lines...) Expand all
22 } 22 }
23 23
24 class DebuggerAgentImpl : public DebuggerAgent { 24 class DebuggerAgentImpl : public DebuggerAgent {
25 public: 25 public:
26 DebuggerAgentImpl(WebViewImpl* web_view_impl, 26 DebuggerAgentImpl(WebViewImpl* web_view_impl,
27 DebuggerAgentDelegate* delegate, 27 DebuggerAgentDelegate* delegate,
28 WebDevToolsAgentImpl* webdevtools_agent); 28 WebDevToolsAgentImpl* webdevtools_agent);
29 virtual ~DebuggerAgentImpl(); 29 virtual ~DebuggerAgentImpl();
30 30
31 // Creates utility context with injected js agent. 31 // Creates utility context with injected js agent.
32 void CreateUtilityContext(WebCore::Document* document, 32 void ResetUtilityContext(WebCore::Document* document,
33 v8::Persistent<v8::Context>* context); 33 v8::Persistent<v8::Context>* context);
34 34
35 // DebuggerAgent implementation. 35 // DebuggerAgent implementation.
36 virtual void DebugBreak(); 36 virtual void DebugBreak();
37 37
38 void DebuggerOutput(const std::string& out); 38 void DebuggerOutput(const std::string& out);
39 39
40 // Executes function with the given name in the utility context. Passes node 40 // Executes function with the given name in the utility context. Passes node
41 // and json args as parameters. Note that the function called must be 41 // and json args as parameters. Note that the function called must be
42 // implemented in the inject.js file. 42 // implemented in the inject.js file.
43 WebCore::String ExecuteUtilityFunction( 43 WebCore::String ExecuteUtilityFunction(
(...skipping 14 matching lines...) Expand all
58 58
59 private: 59 private:
60 WebViewImpl* web_view_impl_; 60 WebViewImpl* web_view_impl_;
61 DebuggerAgentDelegate* delegate_; 61 DebuggerAgentDelegate* delegate_;
62 WebDevToolsAgentImpl* webdevtools_agent_; 62 WebDevToolsAgentImpl* webdevtools_agent_;
63 63
64 DISALLOW_COPY_AND_ASSIGN(DebuggerAgentImpl); 64 DISALLOW_COPY_AND_ASSIGN(DebuggerAgentImpl);
65 }; 65 };
66 66
67 #endif // WEBKIT_GLUE_DEVTOOLS_DEBUGGER_AGENT_IMPL_H_ 67 #endif // WEBKIT_GLUE_DEVTOOLS_DEBUGGER_AGENT_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | webkit/glue/devtools/debugger_agent_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698