Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 10026015: Update uses of TimeDelta in mac bookmark test code. (Closed)

Created:
8 years, 8 months ago by Ted Vessenes
Modified:
8 years, 8 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update uses of TimeDelta in mac bookmark test code. R=jrg@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133402

Patch Set 1 #

Patch Set 2 : Rebase onto master #

Patch Set 3 : Be more precise about float point to int conversions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ted Vessenes
8 years, 8 months ago (2012-04-09 02:36:57 UTC) #1
John Grabowski
lgtm LGTM Thx for the patch!
8 years, 8 months ago (2012-04-10 22:38:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10026015/1
8 years, 8 months ago (2012-04-11 02:37:48 UTC) #3
commit-bot: I haz the power
Try job failure for 10026015-1 (retry) on mac_rel for step "unit_tests". It's a second try, ...
8 years, 8 months ago (2012-04-11 04:49:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10026015/10001
8 years, 8 months ago (2012-04-15 15:25:57 UTC) #5
commit-bot: I haz the power
Try job failure for 10026015-10001 (retry) on mac_rel for step "unit_tests". It's a second try, ...
8 years, 8 months ago (2012-04-15 16:57:33 UTC) #6
Ted Vessenes
I've been poking at this on and off, when I have time, and I'm pretty ...
8 years, 8 months ago (2012-04-19 23:28:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10026015/26002
8 years, 8 months ago (2012-04-23 02:34:16 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 04:01:36 UTC) #9
Change committed as 133402

Powered by Google App Engine
This is Rietveld 408576698