Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 100256: - Add '!' and 'L' status support.... (Closed)

Created:
11 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

- Add '!' and 'L' status support. - Fix gclient revert/status when one of the dependency directory is deleted. - Remove an unneeded svn update after svn checkout. - Updated tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15068

Patch Set 1 #

Patch Set 2 : Fixed tests and added a fix to SCMWrapper.update() #

Total comments: 1

Patch Set 3 : Some test cleanup and added revision support to checkout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -28 lines) Patch
M gclient.py View 1 2 6 chunks +29 lines, -11 lines 0 comments Download
M tests/gclient_test.py View 1 2 4 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
11 years, 7 months ago (2009-05-01 13:54:23 UTC) #1
M-A Ruel
11 years, 7 months ago (2009-05-01 15:14:18 UTC) #2
sgk
lgtm, one possible nit http://codereview.chromium.org/100256/diff/1003/6 File gclient.py (right): http://codereview.chromium.org/100256/diff/1003/6#newcode639 Line 639: elif xml_item_status == 'incomplete' ...
11 years, 7 months ago (2009-05-01 16:31:17 UTC) #3
M-A Ruel
11 years, 7 months ago (2009-05-01 16:54:49 UTC) #4
sgk
11 years, 7 months ago (2009-05-01 17:38:29 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698