Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 100253: Stop inlining of list reallocation in virtual frames. (Closed)

Created:
11 years, 7 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Stop inlining of list reallocation in virtual frames. Committed: http://code.google.com/p/v8/source/detail?r=1835

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -12 lines) Patch
M src/list.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/list-inl.h View 1 2 chunks +27 lines, -12 lines 0 comments Download
M src/virtual-frame.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
Specializes an inlined function that grows a list, so it is not inlined for FrameElements.
11 years, 7 months ago (2009-05-01 11:34:49 UTC) #1
Erik Corry
LGTM
11 years, 7 months ago (2009-05-01 12:41:39 UTC) #2
Dean McNamee
http://codereview.chromium.org/100253/diff/1/4 File src/virtual-frame.cc (right): http://codereview.chromium.org/100253/diff/1/4#newcode528 Line 528: capacity_ = new_capacity; This code looks basically copy ...
11 years, 7 months ago (2009-05-01 12:53:34 UTC) #3
William Hesse
11 years, 7 months ago (2009-05-01 13:53:08 UTC) #4
The change suggested by Dean has been made.  It has been tested on Linux, will
be tested on Windows and ARM before committing.

Powered by Google App Engine
This is Rietveld 408576698