Convert tabs, windows, and extension APIs to feature system.

chrome/common/extensions/feature_unittest.cc

Index: chrome/common/extensions/feature_unittest.cc
diff --git a/chrome/common/extensions/feature_unittest.cc b/chrome/common/extensions/feature_unittest.cc
index c4cc1a3addafdc3c74a463b28097f5ed825450ef..1da5a878f73585292fc9fa59d08544c02988d41c 100644
--- a/chrome/common/extensions/feature_unittest.cc
+++ b/chrome/common/extensions/feature_unittest.cc
@@ -377,6 +377,7 @@ TEST(ExtensionFeatureTest, Inheritance) {
 
 TEST(ExtensionFeatureTest, Equals) {
   Feature feature;
+  feature.set_name("monkey");
   feature.whitelist()->insert("foo");
   feature.extension_types()->insert(Extension::TYPE_THEME);
   feature.contexts()->insert(Feature::UNBLESSED_EXTENSION_CONTEXT);
@@ -388,6 +389,10 @@ TEST(ExtensionFeatureTest, Equals) {
   Feature feature2(feature);
   EXPECT_TRUE(feature2.Equals(feature));
 
+  feature2.set_name("");
+  EXPECT_FALSE(feature2.Equals(feature));
+
+  feature2 = feature;
   feature2.whitelist()->clear();
   EXPECT_FALSE(feature2.Equals(feature));
 
@@ -415,3 +420,32 @@ TEST(ExtensionFeatureTest, Equals) {
   feature2.set_max_manifest_version(0);
   EXPECT_FALSE(feature2.Equals(feature));
 }
+
+TEST(ExtensionFeatureTest, IsEmpty) {
+  Feature feature;
+  EXPECT_TRUE(feature.IsEmpty());
+
+  Feature feature2 = feature;
+  feature2.set_name("monkey");
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.whitelist()->insert("monkey");
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.extension_types()->insert(Extension::TYPE_THEME);
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.contexts()->insert(Feature::CONTENT_SCRIPT_CONTEXT);
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.set_location(Feature::COMPONENT_LOCATION);
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.set_platform(Feature::CHROMEOS_PLATFORM);
+  EXPECT_FALSE(feature2.IsEmpty());
+}