When strings can change from an ASCII representation to a...

When strings can change from an ASCII representation to a
UC16 representation we need to be careful about flat strings.
Flat strings can be sliced or cons strings that have a flat
string under them, so when we ask a flat cons or a slice whether
it is ASCII or not we should ask the underlying string about
its representation.  This should fix
http://code.google.com/p/chromium/issues/detail?id=10971

Committed: http://code.google.com/p/v8/source/detail?r=1830

[Lasse Reichstein, 2009-05-01 09:47:01]

LGTM

http://codereview.chromium.org/100249/diff/1/9
File src/objects-inl.h (right):

http://codereview.chromium.org/100249/diff/1/9#newcode218
Line 218: } else if ((type & kStringRepresentationMask) == kConsStringTag &&
You can omit the "else" here, since the former condition always returns.

http://codereview.chromium.org/100249/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/100249/diff/1/2#newcode6242
Line 6242: "/[^a-z]/.test(slice_on_cons);");
Perhaps add a comment stating what is being tested here (that flattens works).