chrome/browser/autofill/autofill_manager.cc - Issue 10024059: DataList UI (Chromium part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 10024059: DataList UI (Chromium part) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed nits and tests Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autofill/autofill_manager.cc

diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc

index 9a16f3f24bcd42a468823f881af29bdde6d3ef1e..0136f79d0b9e286643ad2957b6c761641926f067 100644

--- a/chrome/browser/autofill/autofill_manager.cc

+++ b/chrome/browser/autofill/autofill_manager.cc

@@ -62,6 +62,7 @@

#include "webkit/forms/form_data_predictions.h"

#include "webkit/forms/form_field.h"

#include "webkit/forms/password_form_dom_manager.h"

+#include "third_party/WebKit/Source/WebKit/chromium/public/WebAutofillClient.h"

using base::TimeTicks;

using content::BrowserThread;

@@ -480,7 +481,8 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,

values.assign(1, l10n_util::GetStringUTF16(warning));

labels.assign(1, string16());

icons.assign(1, string16());

- unique_ids.assign(1, -1);

+ unique_ids.assign(1,

+ WebKit::WebAutofillClient::MenuItemIDWarningMessage);

} else {

bool section_is_autofilled =

SectionIsAutofilled(*form_structure, form,