Issue 10024056: Added functionality to chrome://net-internals/#chromeos page that user

Issue 10024056: Added functionality to chrome://net-internals/#chromeos page that user (Closed)

Created:
8 years, 8 months ago by ygorshenin1

Modified:
8 years, 8 months ago

Reviewers:
eroman, satorux1

CC:
chromium-reviews, eroman, arv (Not doing code reviews), mmenke, Nikita (slow)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Added functionality to chrome://net-internals/#chromeos page that user is able to change network debugging mode without going to crosh. BUG=chromium-os:25701 TEST=Manual testing on Alex device. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132163

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issues are fixed. #

Patch Set 3 : Sync. #

Patch Set 4 : Fixed MockDebugDaemonClient. #

Total comments: 1

Patch Set 5 : Sync. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -10 lines)			Patch
M	chrome/browser/resources/net_internals/browser_bridge.js	View	1 2 3 4	4 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/chromeos_view.html	View	1 2 3 4	1 chunk	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/chromeos_view.js	View	1 2 3 4	7 chunks	+50 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/net_internals/net_internals_ui.cc	View	1 2 3 4	3 chunks	+31 lines, -0 lines	0 comments	Download
M	chromeos/dbus/debug_daemon_client.h	View	1 2 3 4	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chromeos/dbus/debug_daemon_client.cc	View	1 2 3 4	4 chunks	+30 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_debug_daemon_client.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

satorux1

http://codereview.chromium.org/10024056/diff/1/chromeos/dbus/debug_daemon_client.h File chromeos/dbus/debug_daemon_client.h (right): http://codereview.chromium.org/10024056/diff/1/chromeos/dbus/debug_daemon_client.h#newcode29 chromeos/dbus/debug_daemon_client.h:29: // |callback| when completed. how does "subsystem" look like? ...

8 years, 8 months ago (2012-04-10 20:23:12 UTC) #2

ygorshenin1

PTAL http://codereview.chromium.org/10024056/diff/1/chromeos/dbus/debug_daemon_client.h File chromeos/dbus/debug_daemon_client.h (right): http://codereview.chromium.org/10024056/diff/1/chromeos/dbus/debug_daemon_client.h#newcode29 chromeos/dbus/debug_daemon_client.h:29: // |callback| when completed. On 2012/04/10 20:23:12, satorux1 ...

8 years, 8 months ago (2012-04-11 09:04:38 UTC) #4

eroman

LGTM for net_internals code. On Wed, Apr 11, 2012 at 2:04 AM, <ygorshenin@chromium.org> wrote: > ...

8 years, 8 months ago (2012-04-11 09:12:47 UTC) #5

satorux1

LGTM http://codereview.chromium.org/10024056/diff/12002/chromeos/dbus/debug_daemon_client.h File chromeos/dbus/debug_daemon_client.h (right): http://codereview.chromium.org/10024056/diff/12002/chromeos/dbus/debug_daemon_client.h#newcode30 chromeos/dbus/debug_daemon_client.h:30: // following: "wifi", "ethernet", "cellular" or "none". thank ...

8 years, 8 months ago (2012-04-12 17:34:56 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/10024056/13002

8 years, 8 months ago (2012-04-13 07:53:28 UTC) #8

Change committed as 132163

Expand Messages | Collapse Messages