Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: ui/base/resource/resource_bundle_win.cc

Issue 10024050: Metro/HiDPI: Move 1x icons into separate pak file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix hidpi flag Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/resource/resource_bundle_win.cc
diff --git a/ui/base/resource/resource_bundle_win.cc b/ui/base/resource/resource_bundle_win.cc
index 7fcaaf6500857f6432fb21884765d2bfb074f6e8..b82af1436792de73756aaefb17edf3231b4917af 100644
--- a/ui/base/resource/resource_bundle_win.cc
+++ b/ui/base/resource/resource_bundle_win.cc
@@ -5,8 +5,10 @@
#include "ui/base/resource/resource_bundle_win.h"
#include "base/logging.h"
+#include "base/path_service.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/resource/resource_data_dll_win.h"
+#include "ui/base/win/dpi.h"
namespace ui {
@@ -20,11 +22,33 @@ HINSTANCE GetCurrentResourceDLL() {
return GetModuleHandle(NULL);
}
+FilePath GetResourcesPakFilePath(const std::string& pak_name) {
+ FilePath path;
+ if (PathService::Get(base::DIR_MODULE, &path))
+ return path.AppendASCII(pak_name.c_str());
+ return FilePath();
+}
+
} // end anonymous namespace
void ResourceBundle::LoadCommonResources() {
// As a convenience, add the current resource module as a data packs.
data_packs_.push_back(new ResourceDataDLL(GetCurrentResourceDLL()));
+
+ bool use_hidpi_pak = false;
+#if defined(ENABLE_HIDPI)
+ // If we're running in HiDPI mode then use the 2x resource for DPI greater
+ // than 1.5. Otherwise use the 1x resource.
+ use_hidpi_pak = ui::GetDPIScale() > 1.5;
+#endif
+
+ if (!use_hidpi_pak) {
+ AddDataPack(GetResourcesPakFilePath("theme_resources_standard.pak"));
+ AddDataPack(GetResourcesPakFilePath("ui_resources_standard.pak"));
+ } else {
+ AddDataPack(GetResourcesPakFilePath("theme_resources_2x.pak"));
+ AddDataPack(GetResourcesPakFilePath("ui_resources_2x.pak"));
+ }
}
void ResourceBundle::LoadTestResources(const FilePath& path) {

Powered by Google App Engine
This is Rietveld 408576698