Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 10024019: Remove unnecessary references to URLRequestContext. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium
Modified:
8 years, 8 months ago
Reviewers:
eroman, Jói
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Jói
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove unnecessary references to URLRequestContext. The actual URLRequestContext used by the Chromium embedder here is the "proxy script fetcher" URLRequestContext. It is owned by the browser process's IOThread. Therefore, there's no need to refcount it within objects owned by the ProxyService of that URLRequestContext. BUG=58859 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
willchan no longer on Chromium
8 years, 8 months ago (2012-04-09 15:11:22 UTC) #1
eroman
LGTM. cc-ing @joi as FYI
8 years, 8 months ago (2012-04-09 22:41:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10024019/1
8 years, 8 months ago (2012-04-10 06:20:25 UTC) #3
commit-bot: I haz the power
Try job failure for 10024019-1 on android for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&number=8014 Step "update" is always ...
8 years, 8 months ago (2012-04-10 06:52:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10024019/1
8 years, 8 months ago (2012-04-10 08:55:21 UTC) #5
Jói
LGTM, thanks Will.
8 years, 8 months ago (2012-04-10 08:57:08 UTC) #6
commit-bot: I haz the power
Try job failure for 10024019-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=6983 Step "update" is always ...
8 years, 8 months ago (2012-04-10 08:58:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10024019/1
8 years, 8 months ago (2012-04-10 15:09:21 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 16:57:12 UTC) #9
Change committed as 131562

Powered by Google App Engine
This is Rietveld 408576698